Skip to content

Commit c249b44

Browse files
committed
docs: correct stale v3_ste_vec 'committed exception' claim in CLAUDE.md + walkthroughs
1 parent 12a7705 commit c249b44

2 files changed

Lines changed: 7 additions & 13 deletions

File tree

CLAUDE.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,10 @@ cipherstash-client: `mise run test:sqlx:prep` runs `fixture:generate:all` (the
115115
`CS_WORKSPACE_CRN`) AND a client key (`CS_CLIENT_ID` + `CS_CLIENT_KEY`); see the
116116
`test:sqlx:prep` comment in `mise.toml`. CI has them. This is expected, not a reason to avoid
117117
generated fixtures.
118-
- Do NOT add static/committed fixtures to dodge the creds dependency. The one committed
119-
exception, `tests/sqlx/fixtures/v3_ste_vec.sql`, is a gap pending a SteVec-document generator
120-
(`docs/handoff/2026-06-10-v3-jsonb-fixture-alignment.md`), not a pattern to copy.
118+
- Do NOT add static/committed fixtures to dodge the creds dependency. Every fixture is
119+
generated and gitignored — including the SteVec document `tests/sqlx/fixtures/v3_ste_vec.sql`,
120+
which has its own generator (`fixtures::v3_ste_vec::generate()`, run by `generate_all`) and is
121+
gitignored (`.gitignore`) like the rest. There is no committed-fixture exception.
121122

122123
## Project Learning & Retrospectives
123124

docs/walkthroughs/fixture-generator.md

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@ Consequences that shape the whole pipeline:
3737
Every fixture is generated — including the SteVec document
3838
`tests/sqlx/fixtures/v3_ste_vec.sql`, which is gitignored (`.gitignore:228`) and
3939
rebuilt each run by its own generator (`fixtures::v3_ste_vec::generate()`).
40-
(`CLAUDE.md` still calls `v3_ste_vec.sql` "the one committed exception … pending a
41-
SteVec-document generator", but that note is stale: the generator exists and the file
42-
is gitignored like the rest.)
4340

4441
The plaintext **values** are single-sourced in the Rust catalog
4542
`crates/eql-scalars` so the test oracle (the expected-result computation) and the
@@ -285,8 +282,7 @@ compares the DB query result against `expected_forward` over `INT4_VALUES`.
285282
- **`v3_ste_vec`** — a SteVec JSONB document fixture. A hand-written
286283
`FixtureSpec<serde_json::Value>` riding the same `run()` pipeline
287284
(`fixtures::v3_ste_vec::generate()`), gitignored and regenerated like every other
288-
fixture. (`CLAUDE.md` still calls it "the one committed exception"; that wording is
289-
stale — see §6.)
285+
fixture.
290286
- **`v3_doc_int4`** — a scalar-shaped SteVec document, one `{"field": <int4>}` per
291287
`INT4_VALUES`. A **split** fixture: the encryption input is the jsonb document but
292288
the plaintext oracle column is the bare `int4`, so it uses the
@@ -323,11 +319,8 @@ Why not just commit the SQL and skip the creds? Because the ciphertexts must be
323319

324320
> Do NOT add static/committed fixtures to dodge the creds dependency.
325321
326-
(`CLAUDE.md` goes on to name `tests/sqlx/fixtures/v3_ste_vec.sql` as "the one committed
327-
exception … pending a SteVec-document generator", but that clause is stale: the SteVec
328-
generator now exists and the file is gitignored and regenerated like the rest.)
329-
330-
The gitignore enforces it mechanically (`.gitignore:227-230`): every
322+
Every fixture — including `v3_ste_vec.sql` — is generated and gitignored; there is no
323+
committed-fixture exception. The gitignore enforces it mechanically (`.gitignore:227-230`): every
331324
`eql_v2*` fixture plus `v3_ste_vec.sql`, `v3_doc_int4.sql`, and `v3_numeric_collision.sql`
332325
are ignored and regenerated on every `mise run test:sqlx`. A stale or hand-edited fixture
333326
can't survive a run. The live round-trip is additionally smoke-tested by the

0 commit comments

Comments
 (0)