Merge pull request #277 from cipherstash/v3-deny-dead-code

chore: make dead code a compile error + drop dead index_types module

Author: tobyhede

Cargo.toml

@@ -23,3 +23,9 @@ members = [
     "tests/sqlx",
 ]
 default-members = ["tests/sqlx"]
+
+# Dead code is a hard error. Note: rustc exempts unused `pub` items in a lib, so
+# don't `pub` a test-support item unless an integration test consumes it.
+[workspace.lints.rust]
+dead_code = "deny"
+unused_imports = "deny"

crates/eql-codegen/Cargo.toml

@@ -17,3 +17,6 @@ path = "src/main.rs"
 [lib]
 name = "eql_codegen"
 path = "src/lib.rs"
+
+[lints]
+workspace = true

crates/eql-scalars/Cargo.toml

@@ -8,3 +8,6 @@ description = "Scalar/term catalog for EQL encrypted-domain codegen (std-only, n
 # generator (eql-codegen) compiles in ~1-2s and never drags serde/toml onto the
 # SQL build's critical path. Do not add deps here.
 [dependencies]
+
+[lints]
+workspace = true

crates/eql-tests-macros/Cargo.toml

@@ -12,3 +12,6 @@ syn = { version = "2", features = ["full"] }
 quote = "1"
 proc-macro2 = "1"
 eql-scalars = { path = "../eql-scalars" }
+
+[lints]
+workspace = true

tests/sqlx/Cargo.toml

@@ -23,6 +23,9 @@ eql-tests-macros = { path = "../../crates/eql-tests-macros" }
 [dev-dependencies]
 # None needed - tests live in this crate
 
+[lints]
+workspace = true
+
 [features]
 default = []
 # Opt-in to slow benchmark / regression / scale tests. Without this feature

tests/sqlx/src/index_types.rs

@@ -7,7 +7,6 @@ use sqlx::PgPool;
 pub mod assertions;
 pub mod fixtures;
 pub mod helpers;
-pub mod index_types;
 pub mod matrix;
 pub mod scalar_domains;
 #[macro_use]
@@ -37,7 +36,6 @@ pub use helpers::{
     read_pg_stat_statements, reset_pg_stat_statements, ExplainStats, PgStatEntry,
     PLACEHOLDER_PAYLOAD,
 };
-pub use index_types as IndexTypes;
 pub use scalar_domains::{
     assert_null, assert_raises, assert_scalar_plaintexts, blocker_msg, commute_op,
     fetch_fixture_payload, sql_string_literal, ScalarDomainSpec, ScalarType, Variant,