chore(eql-types): inherit workspace lints#289
Open
coderdan wants to merge 1 commit into
Open
Conversation
eql-types was added to the workspace `members` in #236, but its Cargo.toml omitted the `[lints] workspace = true` opt-in that eql-scalars, eql-codegen, and eql-tests-macros all carry — so it was the one member not inheriting the workspace deny-lints (dead_code, unused_imports). Add it for parity. The crate already compiles clean under those lints (verified via `mise run test:crates`).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the eql-types stack (#236 / #268 / #269).
eql-typeswas added to the workspacememberslist in #236, but itsCargo.tomlnever picked up the[lints] workspace = trueopt-in that every other member carries (eql-scalars,eql-codegen,eql-tests-macros). So it was the one workspace crate not inheriting the shared deny-lints:This adds the opt-in so the crate is fully integrated like its siblings. No code changes were needed —
eql-typesalready compiles clean under those lints (mise run test:crates: fmt + clippy-D warnings+ test all pass).Independent of #269 (which is still open); the
[lints]section and #269's dependency additions touch different parts of the file, so they merge cleanly in either order.