Skip to content

chore(eql-types): inherit workspace lints#289

Open
coderdan wants to merge 1 commit into
eql_v3from
dan/eql-types-workspace-lints
Open

chore(eql-types): inherit workspace lints#289
coderdan wants to merge 1 commit into
eql_v3from
dan/eql-types-workspace-lints

Conversation

@coderdan

Copy link
Copy Markdown
Contributor

Follow-up to the eql-types stack (#236 / #268 / #269).

eql-types was added to the workspace members list in #236, but its Cargo.toml never picked up the [lints] workspace = true opt-in that every other member carries (eql-scalars, eql-codegen, eql-tests-macros). So it was the one workspace crate not inheriting the shared deny-lints:

[workspace.lints.rust]
dead_code = "deny"
unused_imports = "deny"

This adds the opt-in so the crate is fully integrated like its siblings. No code changes were needed — eql-types already compiles clean under those lints (mise run test:crates: fmt + clippy -D warnings + test all pass).

Independent of #269 (which is still open); the [lints] section and #269's dependency additions touch different parts of the file, so they merge cleanly in either order.

eql-types was added to the workspace `members` in #236, but its Cargo.toml
omitted the `[lints] workspace = true` opt-in that eql-scalars, eql-codegen,
and eql-tests-macros all carry — so it was the one member not inheriting the
workspace deny-lints (dead_code, unused_imports). Add it for parity. The crate
already compiles clean under those lints (verified via `mise run test:crates`).
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 92491621-f591-408d-9155-2751c80ffe82

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dan/eql-types-workspace-lints

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant