Skip to content

[codex] assert scalar scale predicates are selective#305

Open
tobyhede wants to merge 1 commit into
eql_v3from
eql_v3_scale_index_engagement_expand
Open

[codex] assert scalar scale predicates are selective#305
tobyhede wants to merge 1 commit into
eql_v3from
eql_v3_scale_index_engagement_expand

Conversation

@tobyhede

Copy link
Copy Markdown
Contributor

Summary

  • add row-count assertions to scalar scale-preference matrix predicates
  • reuse each natural/extractor predicate for both EXPLAIN index checks and count(*) selectivity checks
  • leave unrelated untracked docs out of the commit

Validation

  • cargo fmt --check
  • attempted cargo test --features bench --test encrypted_domain -- --list, but the run was interrupted before completion during the long link step

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e3fe5a11-6652-411e-b8e5-23d1a513f329

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch eql_v3_scale_index_engagement_expand

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tobyhede tobyhede changed the base branch from main to eql_v3 June 19, 2026 13:44
@tobyhede tobyhede marked this pull request as ready for review June 19, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant