refactor(stack): remove obsolete v3 freeTextSearch tuner

In v3 the concrete type defines capabilities, so the vestigial v2-style
chainable .freeTextSearch(opts) tuner on EncryptedTextSearchColumn is obsolete.
Remove the method, its matchOpts field, and the build() override that only
cloned tuner opts; default match building is unchanged (the base build() already
emits the default match config for the TextSearch type). The 'freeTextSearch'
query-type/capability is untouched. Drops the now-obsolete tuner tests.

Author: tobyhede

packages/stack/__tests__/schema-v3.test.ts

@@ -22,65 +22,19 @@ describe('eql_v3 text_search column', () => {
     expect(v3).toStrictEqual(v2)
   })
 
-  it('.freeTextSearch(opts) overrides each provided key and keeps the rest as defaults', () => {
-    const built = types
-      .TextSearch('email')
-      .freeTextSearch({
-        tokenizer: { kind: 'ngram', token_length: 4 },
-        k: 8,
-        m: 4096,
-        include_original: false,
-      })
-      .build()
+  it('default build() emits the unique, ore, and match indexes', () => {
+    const built = types.TextSearch('email').build()
+    expect(built.indexes.unique).toEqual({ token_filters: [] })
+    expect(built.indexes.ore).toEqual({})
     expect(built.indexes.match).toEqual({
-      tokenizer: { kind: 'ngram', token_length: 4 },
-      // omitted -> default downcase filter retained
+      tokenizer: { kind: 'ngram', token_length: 3 },
       token_filters: [{ kind: 'downcase' }],
-      k: 8,
-      m: 4096,
-      include_original: false,
+      k: 6,
+      m: 2048,
+      include_original: true,
     })
   })
 
-  it('.freeTextSearch({ token_filters: [] }) overrides the downcase default with an empty array', () => {
-    // LOAD-BEARING: `[] ?? default` evaluates to `[]` (an empty array is not
-    // nullish), so an explicit empty array must OVERRIDE the downcase default,
-    // not fall back to it. Mirrors v2 (schema-builders.test.ts).
-    const built = types
-      .TextSearch('email')
-      .freeTextSearch({ token_filters: [] })
-      .build()
-    expect(built.indexes.match.token_filters).toEqual([])
-  })
-
-  it('repeated .freeTextSearch() calls are last-call-wins-fully (each re-merges against defaults, not prior state)', () => {
-    // Each call re-merges against a fresh defaultMatchOpts(), not the
-    // accumulated matchOpts — so the second call resets k back to its default
-    // of 6. This is intentional: it mirrors v2 exactly. Pinned here so a future
-    // "merge against current state" change can't silently slip in.
-    const built = types
-      .TextSearch('email')
-      .freeTextSearch({ k: 8 })
-      .freeTextSearch({ m: 4096 })
-      .build()
-    expect(built.indexes.match.k).toBe(6)
-    expect(built.indexes.match.m).toBe(4096)
-  })
-
-  it('.freeTextSearch() with no argument is a no-op: build() equals the default build()', () => {
-    // Pins the opts === undefined branch: every `opts?.x ?? default` falls
-    // through, so a bare call must emit exactly the default match block.
-    expect(types.TextSearch('email').freeTextSearch().build()).toStrictEqual(
-      types.TextSearch('email').build(),
-    )
-  })
-
-  it('.freeTextSearch() is tuning-only: unique and ore indexes stay present', () => {
-    const built = types.TextSearch('email').freeTextSearch({ k: 8 }).build()
-    expect(built.indexes.unique).toEqual({ token_filters: [] })
-    expect(built.indexes.ore).toEqual({})
-  })
-
   it('built columns share no mutable state: mutating one build() output does not affect another', () => {
     // Guards against the shared-defaults aliasing bug: defaults come from a
     // per-instance factory and build() deep-clones the match block.
@@ -104,29 +58,6 @@ describe('eql_v3 text_search column', () => {
     expect(c.indexes.match.k).toBe(6)
     expect(c.indexes.match.token_filters).toEqual([{ kind: 'downcase' }])
   })
-
-  it('clones caller opts on freeTextSearch(): mutating them before build() does not leak', () => {
-    // build() deep-clones at build time, but if freeTextSearch stored the
-    // caller's nested tokenizer / token_filters by reference, a caller mutating
-    // their own opts object between freeTextSearch(opts) and build() would leak
-    // the mutation into the emitted config. freeTextSearch must clone on write.
-    const opts = {
-      tokenizer: { kind: 'ngram' as const, token_length: 3 },
-      token_filters: [{ kind: 'downcase' as const }],
-    }
-    const col = types.TextSearch('email').freeTextSearch(opts)
-
-    // Mutate the caller's own opts AFTER freeTextSearch but BEFORE build().
-    opts.tokenizer.token_length = 999
-    opts.token_filters.push({ kind: 'downcase' as const })
-
-    const built = col.build()
-    expect(built.indexes.match.tokenizer).toEqual({
-      kind: 'ngram',
-      token_length: 3,
-    })
-    expect(built.indexes.match.token_filters).toEqual([{ kind: 'downcase' }])
-  })
 })
 
 describe('eql_v3 text_match column', () => {

packages/stack/src/eql/v3/columns.ts

@@ -1,10 +1,5 @@
-import type { ColumnSchema, MatchIndexOpts } from '@/schema'
-import {
-  type BuiltMatchIndexOpts,
-  cloneMatchOpts,
-  defaultMatchOpts,
-  resolveMatchOpts,
-} from '@/schema/match-defaults'
+import type { ColumnSchema } from '@/schema'
+import { defaultMatchOpts } from '@/schema/match-defaults'
 
 /**
  * The query capabilities a v3 concrete domain exposes. These are SDK-facing
@@ -155,7 +150,7 @@ export const SMALLINT_ORD = {
 // bigint (int8) domains. Plaintext is a JS `bigint` (always decrypts to
 // `bigint`); bounds are the full i64 range, enforced at the protect-ffi
 // boundary, which round-trips a native bigint losslessly. (`*_ord_ope`
-// variants are out of scope — CIP-3403.)
+// variants are out of scope for this change.)
 export const BIGINT = {
   eqlType: 'public.bigint',
   castAs: 'bigint',
@@ -424,8 +419,8 @@ const TEXT_SEARCH_DOMAIN = {
  * Builder for a `public.text_search` column.
  *
  * The concrete type inherently enables equality + order/range + free-text
- * match — there are no capability-enabling methods. `.freeTextSearch(opts?)`
- * tunes the match index only.
+ * match — there are no capability-enabling or tuning methods. The match index
+ * is always emitted with the default configuration.
  *
  * NOTE — querying: a `text_search` column emits all three indexes (`unique`,
  * `ore`, `match`), and the shared index-inference picks them by fixed priority
@@ -444,45 +439,8 @@ const TEXT_SEARCH_DOMAIN = {
 export class EncryptedTextSearchColumn extends EncryptedV3Column<
   typeof TEXT_SEARCH_DOMAIN
 > {
-  private matchOpts: BuiltMatchIndexOpts
-
   constructor(columnName: string) {
     super(columnName, TEXT_SEARCH_DOMAIN)
-    this.matchOpts = defaultMatchOpts()
-  }
-
-  /**
-   * Tune the match index. Each provided key replaces its default; omitted
-   * keys keep the default. This NEVER enables a capability — match is always
-   * on for this type. Merge semantics mirror v2's `opts?.x ?? default`.
-   */
-  freeTextSearch(opts?: MatchIndexOpts): this {
-    // Shared merge+clone (schema/match-defaults) — one source of truth with the
-    // v2 `freeTextSearch()` builder. `resolveMatchOpts` merges each key over the
-    // per-call defaults and deep-clones, so a caller mutating their own opts
-    // object between `freeTextSearch(opts)` and `build()` cannot leak into the
-    // emitted config (clone-on-write).
-    this.matchOpts = resolveMatchOpts(opts)
-    return this
-  }
-
-  /** Emit the encrypt-config column. Byte-identical to a v2 equality+order+match column. */
-  override build(): ColumnSchema {
-    // Derive `cast_as` + the `unique`/`ore` blocks from the shared
-    // capability→index mapping (this domain's TEXT_SEARCH capabilities produce
-    // exactly `{ unique, ore, match }`), then override ONLY `match` with this
-    // builder's tuned opts. Hand-writing the unique/ore shape here would let it
-    // silently drift from `indexesForCapabilities` — the exact divergence class
-    // behind the text_ord `hm`-index bug. Deep-clone the match block so the
-    // returned config never aliases this builder's internal `matchOpts`.
-    const base = super.build()
-    return {
-      ...base,
-      indexes: {
-        ...base.indexes,
-        match: cloneMatchOpts(this.matchOpts),
-      },
-    }
   }
 }
 

packages/stack/src/eql/v3/types.ts

@@ -103,9 +103,10 @@ import {
  * })
  * ```
  *
- * `types.TextSearch` keeps the chainable `.freeTextSearch(opts)` tuner (the
- * only capability-bearing chain — every other domain is fully described by its
- * type).
+ * `types.TextSearch` is fully described by its type — like every other domain,
+ * it has no capability-bearing or tuning chain. Its match index is always
+ * emitted with the default configuration; run a free-text query by passing
+ * `queryType: 'freeTextSearch'` to `encryptQuery`.
  */
 export const types = {
   // integer