Skip to content

Commit bcaccc9

Browse files
fix lint issues
1 parent 7e8531d commit bcaccc9

2 files changed

Lines changed: 22 additions & 6 deletions

File tree

crates/malachite-app/src/handlers/started_round.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,15 @@ async fn on_started_round(
9999

100100
if round.as_i64() > 0 {
101101
let current_round = round.as_u32().expect("round is defined");
102-
let missed_round = Round::new(current_round - 1);
102+
let missed_round = Round::new(current_round.saturating_sub(1));
103103
let missed_proposer = state
104104
.ctx
105105
.proposer_selector
106106
.select_proposer(state.validator_set(), height, missed_round)
107107
.address;
108-
state.metrics().inc_consensus_round_missed(missed_proposer, height, missed_round);
108+
state
109+
.metrics()
110+
.inc_consensus_round_missed(missed_proposer, height, missed_round);
109111
}
110112

111113
state.current_round = round;

crates/malachite-app/src/metrics/app.rs

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,12 @@ impl AppMetrics {
488488

489489
/// Total number of missed consensus rounds since start.
490490
#[cfg(test)]
491-
pub fn get_consensus_round_missed_count(&self, proposer: Address, height: Height, round: Round) -> u64 {
491+
pub fn get_consensus_round_missed_count(
492+
&self,
493+
proposer: Address,
494+
height: Height,
495+
round: Round,
496+
) -> u64 {
492497
self.consensus_round_missed
493498
.get_or_create(&RoundMissedLabel::new(proposer, height, round))
494499
.get()
@@ -705,8 +710,17 @@ mod tests {
705710
metrics.inc_consensus_round_missed(proposer, Height::new(2), Round::new(0));
706711
metrics.inc_consensus_round_missed(proposer, Height::new(2), Round::new(1));
707712

708-
assert_eq!(metrics.get_consensus_round_missed_count(proposer, Height::new(1), Round::new(0)), 1);
709-
assert_eq!(metrics.get_consensus_round_missed_count(proposer, Height::new(2), Round::new(0)), 1);
710-
assert_eq!(metrics.get_consensus_round_missed_count(proposer, Height::new(2), Round::new(1)), 1);
713+
assert_eq!(
714+
metrics.get_consensus_round_missed_count(proposer, Height::new(1), Round::new(0)),
715+
1
716+
);
717+
assert_eq!(
718+
metrics.get_consensus_round_missed_count(proposer, Height::new(2), Round::new(0)),
719+
1
720+
);
721+
assert_eq!(
722+
metrics.get_consensus_round_missed_count(proposer, Height::new(2), Round::new(1)),
723+
1
724+
);
711725
}
712726
}

0 commit comments

Comments
 (0)