"metric reset" disable via http header#88
Open
yargevad wants to merge 4 commits into
Open
Conversation
…least `{"circonus_agent":{"_type":"s","_value":"circonus-agent_Dev"}}` in the response)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our use case for this is post-deploy verification testing of metrics pushed to
/write- we want to see the metric data, but don't want our test to consume it, causing a dip in metrics and false positive alerts.I changed a couple tests in the same directory as the other files I was touching to expect
http.StatusOKinstead ofhttp.StatusNoContentsince that's what the endpoints were returning. I can revert that if you prefer to address those tests separately.