Skip to content

DRAFT: CIRC-4436 - Allow stacktrace across an eventer asynch#740

Open
vasuraman11 wants to merge 2 commits into
masterfrom
ci-CIRC-4436.stacktrace_across_asynch
Open

DRAFT: CIRC-4436 - Allow stacktrace across an eventer asynch#740
vasuraman11 wants to merge 2 commits into
masterfrom
ci-CIRC-4436.stacktrace_across_asynch

Conversation

@vasuraman11
Copy link
Copy Markdown
Contributor

This branch allows libmtev to stacktrace beyond mtev_run_callback and show what the stacktrace was when eventer_add was called. That allows us to get a greater context if a crash occurs.

@vasuraman11 vasuraman11 requested a review from postwait November 25, 2020 05:38
Copy link
Copy Markdown
Member

@postwait postwait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This increases the eventer_t by over a kilobyte.

This should be implemented as an optional module that leverages the existing eventer_context_t as zipkin does.

@postwait
Copy link
Copy Markdown
Member

I also thing that zipking provides a lot of this already. I think we should close this for a different approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants