Fixed idempotency in user_rolw_workflow_manager#32
Merged
Conversation
madhansansel
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
In user_role_workflow_manager.py, idempotency was breaking during user_requires_update() because the module compared the desired role against the current role too literally.
The module resolves that role name to a role ID from get_roles_api. But Catalyst Center may return the existing user’s roleList
The fix normalizes both sides before comparing:
Resolve every desired role name to its role ID.
Normalize the current roleList by converting any role names returned by Catalyst Center back to role IDs.
Compare the resulting role ID sets instead of comparing only the first list item.