Update: Enhance Readme#37
Open
Quy-1009 wants to merge 4 commits into
Open
Conversation
DNACENSolutions
requested changes
Jun 28, 2026
| -vvvv | ||
| ``` | ||
|
|
||
| > `VARS_FILE_PATH` is resolved relative to the playbook directory, so you can also use the shorter form `--extra-vars "VARS_FILE_PATH=../vars/accesspoint_config_inputs.yml"`. |
There was a problem hiding this comment.
remove this one. we should document only absolute path, as customer may have their playbook and cars file at different location.
|
|
||
| ```bash | ||
| ansible-playbook -i ./inventory/demo_lab/hosts.yaml \ | ||
| ./cvp/accesspoint_config_generator/playbook/accesspoint_config_generator.yml \ |
There was a problem hiding this comment.
you should not test fro with in the collection, but from your own test project and give an absolute path to the playbooks from your project.
|
|
||
| ```bash | ||
| (pyats) bash-4.4$ ./tools/schemavalidation.sh \ | ||
| -s cvp/accesspoint_config_generator/schema/accesspoint_config_schema.yml \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Documentation cleanup for workflows under
cvp/:cvp/network_settings/README.mdto match the schema (parentName→parent_name,site_type→type, fixed types fortimezone/dhcp_server/ntp_server)./Users/majlona/...fromcvp/sda_fabric_device_roles/README.md../tools/schemavalidation.shwith the corresponding schema/vars pair.Impact: Documentation only — no changes to playbooks, roles, schemas, or vars files.
Testing Done:
schema_path/vars_pathreferenced in the new validate sections exists on disk andyamalepasses.Checklist
Ansible Best Practices
Documentation
Notes to Reviewers
cvp/network_settings/README.mdmatching the schema, (2) schema/vars paths in the new validate sections.##Xheadings missing a space, hardcoded IPs) — out of scope, will be addressed in a follow-up PR.