Skip to content

fix: support viptela-* image naming in get_cml_sdwan_image_definition #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ken130480 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: support viptela-* image naming in get_cml_sdwan_image_definition #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions catalyst_sdwan_lab/tasks/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,12 @@ def get_cml_sdwan_image_definition(
if requested_image_definition in existing_image_definitions:
return requested_image_definition
else:
# Fallback: match by version string in image ID.
# Handles cases where images were registered manually with viptela-* naming
# (e.g. viptela-vmanage-20.12.7.1) instead of the expected cat-sdwan-* convention.
version_matches = [img for img in existing_image_definitions if software_version in img]
if version_matches:
return version_matches[0]
if node_definition in ["cat-sdwan-controller", "cat-sdwan-validator"]:
# If there's no requested Controller image, try one version lower
# For example sometimes Manager is 20.9.3.2 and Controller/Validator is 20.9.3.1
Expand Down