Skip to content

Commit 26b274c

Browse files
committed
add timesheetHours filter
1 parent b089cb4 commit 26b274c

5 files changed

Lines changed: 27 additions & 4 deletions

File tree

queries/employees/getTimesheetBatchEntries.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ export interface GetTimesheetBatchEntriesFilters {
88
activityId?: string;
99
jobId?: string;
1010
workOrderNumber?: string;
11+
timesheetHours?: number;
1112
}
1213
/**
1314
* Retrieves timesheet batch entries based on provided filters.

queries/employees/getTimesheetBatchEntries.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,17 @@ export async function getTimesheetBatchEntries(mssqlConfig, filters) {
5050
if (filters.workOrderNumber !== undefined) {
5151
sql += ' AND [WONOS] = @workOrderNumber';
5252
}
53+
if (filters.timesheetHours !== undefined) {
54+
sql += ' AND [Qty] = @timesheetHours';
55+
}
5356
sql += ' order by [BatchSysID] desc, [SeqNo]';
5457
const result = (await request
5558
.input('employeeNumber', filters.employeeNumber)
5659
.input('timesheetDate', filters.timesheetDate)
5760
.input('jobId', filters.jobId)
5861
.input('activityId', filters.activityId)
5962
.input('workOrderNumber', filters.workOrderNumber)
63+
.input('timesheetHours', filters.timesheetHours)
6064
.query(sql));
6165
return result.recordset;
6266
}

queries/employees/getTimesheetBatchEntries.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ export interface GetTimesheetBatchEntriesFilters {
1212
activityId?: string
1313
jobId?: string
1414
workOrderNumber?: string
15+
16+
timesheetHours?: number
1517
}
1618

1719
/**
@@ -74,6 +76,10 @@ export async function getTimesheetBatchEntries(
7476
sql += ' AND [WONOS] = @workOrderNumber'
7577
}
7678

79+
if (filters.timesheetHours !== undefined) {
80+
sql += ' AND [Qty] = @timesheetHours'
81+
}
82+
7783
sql += ' order by [BatchSysID] desc, [SeqNo]'
7884

7985
const result = (await request
@@ -82,6 +88,7 @@ export async function getTimesheetBatchEntries(
8288
.input('jobId', filters.jobId)
8389
.input('activityId', filters.activityId)
8490
.input('workOrderNumber', filters.workOrderNumber)
91+
.input('timesheetHours', filters.timesheetHours)
8592
.query(sql)) as mssql.IResult<TimesheetBatchEntry>
8693

8794
return result.recordset

test/employees.test.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,16 @@ await describe('queries/employees', async () => {
3636
});
3737
});
3838
await describe('getTimesheetBatchEntries()', async () => {
39-
await it('Retrieves timesheet batch entries by employee number', async () => {
39+
await it('Retrieves timesheet batch entries by employee number and hours', async () => {
40+
const timesheetHours = 8;
4041
const timesheetBatchEntries = await getTimesheetBatchEntries(mssqlConfig, {
41-
employeeNumber: validEmployeeNumber
42+
employeeNumber: validEmployeeNumber,
43+
timesheetHours
4244
});
4345
assert.ok(timesheetBatchEntries.length > 0);
4446
for (const timesheetBatchEntry of timesheetBatchEntries) {
4547
assert.strictEqual(timesheetBatchEntry.employeeNumber, validEmployeeNumber);
48+
assert.strictEqual(timesheetBatchEntry.timesheetHours, timesheetHours);
4649
}
4750
});
4851
await it('Retrieves timesheet batch entries by employee number and date', async () => {

test/employees.test.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,14 @@ await describe('queries/employees', async () => {
5353
})
5454

5555
await describe('getTimesheetBatchEntries()', async () => {
56-
await it('Retrieves timesheet batch entries by employee number', async () => {
56+
await it('Retrieves timesheet batch entries by employee number and hours', async () => {
57+
const timesheetHours = 8
58+
5759
const timesheetBatchEntries = await getTimesheetBatchEntries(
5860
mssqlConfig,
5961
{
60-
employeeNumber: validEmployeeNumber
62+
employeeNumber: validEmployeeNumber,
63+
timesheetHours
6164
}
6265
)
6366

@@ -68,6 +71,11 @@ await describe('queries/employees', async () => {
6871
timesheetBatchEntry.employeeNumber,
6972
validEmployeeNumber
7073
)
74+
75+
assert.strictEqual(
76+
timesheetBatchEntry.timesheetHours,
77+
timesheetHours
78+
)
7179
}
7280
})
7381

0 commit comments

Comments
 (0)