Pass in contribution_id to membership.create when chaining for profil…

[mattwire]

…es so that lineitems are correctly linked to the contribution straight away

Partial from #35082

Overview

Membership gets created first with lineitems that then have to be linked up to contribution later.

Just create the contribution first and chain it through to membership

Before

Membership created first, we don't have contribution yet.

After

Contribution created first, then passed to Membership create.

Technical Details

Described in code comments

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[eileenmcnaughton]

@mattwire I think it would be good to deprecate this api but definitely to deprecate passing contribution_id into Membership:create - we could do extra handling in the Profile.create api to create the contribution - e.g call the order api instead.....

[mattwire]

@mattwire I think it would be good to deprecate this api but definitely to deprecate passing contribution_id into Membership:create - we could do extra handling in the Profile.create api to create the contribution - e.g call the order api instead.....

I agree, but was trying to do minimal changes here so I can get LineItem writerecord PR over the line.

[eileenmcnaughton]

@mattwire yeah - I'm still getting there on whether I agree with your approach on that - just trying to deal with all this noise - all the work I'd done prior had gotten me to thinking LineItem.create should only write line items & we should have one or two functions that handle the financial item business logic - but at the moment there are all these other things flying past so trying to make sure we aren't adding to things that should be deprecated