Skip to content

Find out cause of test fails#35663

Merged
seamuslee001 merged 1 commit into
civicrm:masterfrom
eileenmcnaughton:test_check
May 18, 2026
Merged

Find out cause of test fails#35663
seamuslee001 merged 1 commit into
civicrm:masterfrom
eileenmcnaughton:test_check

Conversation

@eileenmcnaughton
Copy link
Copy Markdown
Contributor

I think it might be a natural order sort thing - but started failing

Overview

A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

I think it might be a natural order sort thing - but started failing
@civibot
Copy link
Copy Markdown

civibot Bot commented May 13, 2026

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot Bot added the master label May 13, 2026
@eileenmcnaughton eileenmcnaughton deleted the test_check branch May 14, 2026 00:00
@eileenmcnaughton eileenmcnaughton restored the test_check branch May 14, 2026 06:04
@eileenmcnaughton
Copy link
Copy Markdown
Contributor Author

And they are failing again - time related???

@eileenmcnaughton
Copy link
Copy Markdown
Contributor Author

test this please

@eileenmcnaughton
Copy link
Copy Markdown
Contributor Author

I think this will do it #35669

@eileenmcnaughton
Copy link
Copy Markdown
Contributor Author

test this please

@eileenmcnaughton
Copy link
Copy Markdown
Contributor Author

@seamuslee001 may as well merge - information improved on fail - if it happens again

@seamuslee001 seamuslee001 merged commit e94fa9d into civicrm:master May 18, 2026
1 check passed
@seamuslee001 seamuslee001 deleted the test_check branch May 18, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants