Skip to content

SearchKit - load first run as fast as possible, but not too fast#35683

Open
ufundo wants to merge 2 commits into
civicrm:masterfrom
ufundo:search-kit-first-load
Open

SearchKit - load first run as fast as possible, but not too fast#35683
ufundo wants to merge 2 commits into
civicrm:masterfrom
ufundo:search-kit-first-load

Conversation

@ufundo
Copy link
Copy Markdown
Contributor

@ufundo ufundo commented May 15, 2026

Overview

Alternative attempt to gain the 600ms on first search kit load

@civibot
Copy link
Copy Markdown

civibot Bot commented May 15, 2026

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot Bot added the 6.15 label May 15, 2026
@ufundo ufundo marked this pull request as ready for review May 15, 2026 09:25
@civibot
Copy link
Copy Markdown

civibot Bot commented May 15, 2026

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/6493

@colemanw
Copy link
Copy Markdown
Member

Issue found while testing:

  1. Set up a search display + afform
  2. Expose a couple filters to the form + enable "save filters"
  3. View the page & enter some filters
  4. Refresh the page
  5. On page load the search runs, then immediate runs again resulting in a flash of results appearing, disappearing, and reappearing.

I think for the RC we should just do the revert: #35692

@ufundo ufundo marked this pull request as draft May 21, 2026 15:50
@ufundo ufundo changed the base branch from 6.15 to master May 21, 2026 15:51
@civibot civibot Bot added master and removed 6.15 labels May 21, 2026
@ufundo ufundo changed the title dev/core#6493 - fix respecting filter input default values on SearchKit first load [RC] SearchKit - load first run as fast as possible, but not too fast May 21, 2026
@ufundo
Copy link
Copy Markdown
Contributor Author

ufundo commented May 21, 2026

Good catch @colemanw

Have merged the straight reverts and redirected this to master.

The whackamole for your bug is to disable in the case there is store-values. But it feels... whackamole. I sort of wonder if we should just concede the 600ms. I can't see how we are going to reliably ensure we have everything for the "final" first load.

@ufundo ufundo force-pushed the search-kit-first-load branch from 184da23 to bda98a0 Compare May 21, 2026 16:06
@ufundo ufundo marked this pull request as ready for review May 22, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants