SearchKit - load first run as fast as possible, but not too fast#35683
Open
ufundo wants to merge 2 commits into
Open
SearchKit - load first run as fast as possible, but not too fast#35683ufundo wants to merge 2 commits into
ufundo wants to merge 2 commits into
Conversation
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
|
The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/6493 |
3c3161a to
184da23
Compare
Member
|
Issue found while testing:
I think for the RC we should just do the revert: #35692 |
Contributor
Author
|
Good catch @colemanw Have merged the straight reverts and redirected this to master. The whackamole for your bug is to disable in the case there is store-values. But it feels... whackamole. I sort of wonder if we should just concede the 600ms. I can't see how we are going to reliably ensure we have everything for the "final" first load. |
184da23 to
bda98a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Alternative attempt to gain the 600ms on first search kit load