readability improvements

Author: cjbarth

lib/src/Gren.js

@@ -1301,24 +1301,26 @@ class Gren {
     // 1) Build quick lookup
     const commitMap = new Map(commits.map((c) => [c.sha, c]));
 
-    // 2) Compute in‑list parents for each commit
+    // 2) Compute parents for each commit
     const parentMap = new Map();
     for (const c of commits) {
-      const inList = (c.parents || []).map((p) => p.sha).filter((sha) => commitMap.has(sha));
-      parentMap.set(c.sha, inList);
+      const parentList = (c.parents || []).map((p) => p.sha).filter((sha) => commitMap.has(sha));
+      parentMap.set(c.sha, parentList);
     }
 
-    // 3) Compute which SHAs appear as a parent → those that have children
+    // 3) Compute which SHAs appear as a parent -> those that have children
     const hasChild = new Set();
     for (const parents of parentMap.values()) {
-      for (const p of parents) hasChild.add(p);
+      for (const p of parents) {
+        hasChild.add(p);
+      }
     }
 
     // 4) Heads = commits that never appear as anyone’s parent
     const heads = commits.filter((c) => !hasChild.has(c.sha)).map((c) => c.sha);
 
     // 5) A helper to compare by newest date
-    const compareDateDesc = (shaA) => (shaB) => {
+    const compareDateDesc = (shaA, shaB) => {
       const da = new Date(
         commitMap.get(shaA).commit.committer.date || commitMap.get(shaA).commit.author.date,
       );
@@ -1335,7 +1337,7 @@ class Gren {
 
     while (pool.length) {
       // pick the newest SHA
-      pool.sort((a, b) => compareDateDesc(a)(b));
+      pool.sort((a, b) => compareDateDesc(a, b));
       const sha = pool.shift();
 
       if (seen.has(sha)) continue;
@@ -1344,7 +1346,7 @@ class Gren {
       // emit that commit
       result.push(commitMap.get(sha));
 
-      // add its in‑list parents to the pool
+      // add its parents to the pool
       for (const p of parentMap.get(sha) || []) {
         if (!seen.has(p)) pool.push(p);
       }