ffi: Refactor to simpler API.#4
Merged
Merged
Conversation
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Colin!
After chatting with Matteo, we would like to propose a simplified API.
This is also inspired by Bun existing API.
I started this PR on top of yours.
This explicitly manipulates pointers and raw memory and thus avoid need for many wrapper objects that do not provide additional safety.
API examples
Before
After
Main changes
DynamicLibraryand rawbigintpointers.UnsafePointer,UnsafePointerView,UnsafeFnPointer,UnsafeCallback, and struct-descriptor APIs are removed.dlopen()now returns{ lib, functions }: callable wrappers live infunctions, while resolved symbol addresses are exposed asbigints.dlclose(),dlsym(),get*()/set*(),toString(),toBuffer(),toArrayBuffer(),exportString(), andexportBuffer().registerCallback()/unregisterCallback()/refCallback()/unrefCallback().src/node_ffi.*plus shared type/memory helpers.--without-ffi, with added support for shared libffi via--shared-ffi*options.