fix: Various improvements.#6
Merged
Merged
Conversation
ShogunPanda
force-pushed
the
ffi
branch
5 times, most recently
from
40db774 to
570ba85
Compare
cjihrig
reviewed
Mar 22, 2026
cjihrig
left a comment
cjihrig
left a comment
Owner
There was a problem hiding this comment.
Left a number of comments. I didn't make it through everything, but it seems like maybe some rogue AI made some inadvisable changes.
Author
|
@cjihrig I reverted many unneeded changes. Do you mind checking again? |
Owner
|
Thanks. I left a comment about exception handling in C++. I will take a more in depth look again later. |
Author
|
Thanks, I didn't know about exception handling. I replaced all of them with simple returns. |
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
cjihrig
reviewed
Mar 24, 2026
| os.environ.get('VSCMD_ARG_TGT_ARCH'), | ||
| os.environ.get('Platform'), | ||
| os.environ.get('PROCESSOR_ARCHITECTURE'), | ||
| platform.machine(), |
Owner
There was a problem hiding this comment.
I don't know Python, but is there any reason not to only rely on platform.machine()?
Author
There was a problem hiding this comment.
No idea, I trusted AI on this :)
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Author
|
@cjihrig Finally everything is green. This should be ready to be merged! |
ShogunPanda
added a commit
that referenced
this pull request
Apr 6, 2026
* src,deps,test: various improvements Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps,test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps,test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps,test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps,test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * doc,lib: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> --------- Signed-off-by: Paolo Insogna <paolo@cowtech.it>
ShogunPanda
added a commit
that referenced
this pull request
Apr 11, 2026
* src,deps,test: various improvements Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps,test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps,test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps,test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps,test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * doc,lib: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> --------- Signed-off-by: Paolo Insogna <paolo@cowtech.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.