Overlapping of lists next to floating tables.#17741
Draft
pszczesniak wants to merge 7 commits into
Draft
Conversation
Reinmar
reviewed
Apr 16, 2025
| .ck-content .table-style-align-left ~ ul ol, | ||
| .ck-content .table-style-align-left ~ ol ol, | ||
| .ck-content .table-style-align-left ~ ol ul { | ||
| overflow: hidden; |
Member
There was a problem hiding this comment.
This is risky. All overflow:hidden caused issues in the past.
Eg. if someone has bullets styled with some custom elements outside ol/ul, they will not show up.
Member
|
One quick note: Apart from the issues with overflow:hidden, this solution won't handle scenarios like img+h1+ol :( |
Collaborator
|
There has been no activity on this PR for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the contribution, leave a comment or reaction under this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Type: Message. Closes #8412.
Additional information
This is not 100% super solid solution but some kind of a workaround for this problem.
Description:
In
Tablesthe change were made from inline styles that were responsible for floating to CSS classes. That helped to addmargin-inline-endwith value of2emto preserve the space when lists were next to the floating table. Also by this class there is a chance to set on the listsoverflow: hiddenandpadding-inline-start(starting from the second nesting ONLY) when they are preceded by an element with CSS class mention earlier.The only potential risk is the
overflow: hidden, but regular user wont' be able to break anything - without specific CSS that could manipulate the content (likeposition: absoluteand manipulating thetop,left,rightorbottom).Before:
After:
Export to Word.