Skip to content

Commit a6b659a

Browse files
authored
Merge pull request #630 from ckormanyos/comments_and_syntax
Improve comments and trivial syntax
2 parents 96ecad1 + 479d357 commit a6b659a

5 files changed

Lines changed: 21 additions & 26 deletions

File tree

ref_app/target/micros/xtensa_esp32_s3/startup/coprocessor_binary.S

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ coprocessor_bin:
2020
.byte 0x01, 0xA0, 0x00, 0x00, 0x37, 0x15, 0x00, 0x50, 0x13, 0x05, 0x05, 0x0B, 0x82, 0x80, 0x00, 0x00
2121
.byte 0x41, 0x11, 0x06, 0xC6, 0xC5, 0x3F, 0x83, 0x47, 0x05, 0x00, 0x81, 0xE7, 0x85, 0x47, 0x23, 0x00
2222
.byte 0xF5, 0x00, 0xB2, 0x40, 0x41, 0x01, 0x82, 0x80, 0x01, 0x45, 0x81, 0x45, 0x82, 0x80, 0x00, 0x00
23-
.byte 0x82, 0x80, 0x00, 0x00, 0x23, 0x14, 0xB5, 0x00, 0x82, 0x80, 0x00, 0x00, 0x82, 0x80, 0x00, 0x00
24-
.byte 0x05, 0x45, 0x82, 0x80, 0x00, 0x00, 0x00, 0x00, 0xB1, 0x45, 0x09, 0xB7, 0x41, 0x11, 0x01, 0x45
23+
.byte 0x82, 0x80, 0x00, 0x00, 0x05, 0x45, 0x82, 0x80, 0x00, 0x00, 0x00, 0x00, 0x23, 0x14, 0xB5, 0x00
24+
.byte 0x82, 0x80, 0x00, 0x00, 0x82, 0x80, 0x00, 0x00, 0xB1, 0x45, 0x09, 0xB7, 0x41, 0x11, 0x01, 0x45
2525
.byte 0x06, 0xC6, 0xF9, 0x3F, 0xB2, 0x40, 0x01, 0x45, 0x41, 0x01, 0x5D, 0xBF, 0x00, 0x00, 0x00, 0x00
2626
.byte 0x41, 0x11, 0x06, 0xC6, 0xE5, 0x37, 0x37, 0x17, 0x00, 0x50, 0x13, 0x07, 0x47, 0x0B, 0x83, 0x57
2727
.byte 0x67, 0x00, 0x83, 0x55, 0x47, 0x00, 0xB7, 0x1E, 0x00, 0x50, 0xA9, 0x66, 0x37, 0x08, 0x00, 0xF8
@@ -257,8 +257,8 @@ coprocessor_bin:
257257
.byte 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
258258
.byte 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
259259
.byte 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
260-
.byte 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x3C, 0x01, 0x00, 0x50, 0x48, 0x01, 0x00, 0x50
261-
.byte 0x40, 0x01, 0x00, 0x50, 0x34, 0x01, 0x00, 0x50, 0x01, 0x00, 0x02, 0x00, 0x03, 0x00, 0x04, 0x00
260+
.byte 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x44, 0x01, 0x00, 0x50, 0x48, 0x01, 0x00, 0x50
261+
.byte 0x34, 0x01, 0x00, 0x50, 0x3C, 0x01, 0x00, 0x50, 0x01, 0x00, 0x02, 0x00, 0x03, 0x00, 0x04, 0x00
262262
.byte 0x05, 0x00, 0x06, 0x00, 0x07, 0x00, 0x08, 0x00, 0x09, 0x00, 0x0A, 0x00, 0x0B, 0x00, 0x0C, 0x00
263263
.byte 0x0D, 0x00, 0x0E, 0x00, 0x0F, 0x00, 0x10, 0x00, 0x11, 0x00, 0x12, 0x00, 0x13, 0x00, 0x14, 0x00
264264
.byte 0x15, 0x00, 0x16, 0x00, 0x17, 0x00, 0x18, 0x00, 0x19, 0x00, 0x1A, 0x00, 0x1B, 0x00, 0x1C, 0x00

ref_app/target/micros/xtensa_esp32_s3_riscv_cop/make/xtensa_esp32_s3_riscv_cop_flags.gmk

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright Christopher Kormanyos 2022 - 2024.
1+
# Copyright Christopher Kormanyos 2022 - 2025.
22
# Distributed under the Boost Software License,
33
# Version 1.0. (See accompanying file LICENSE_1_0.txt
44
# or copy at http://www.boost.org/LICENSE_1_0.txt)
@@ -26,15 +26,6 @@ WARN_FLAGS := -Wall
2626
-Wunreachable-code \
2727
-Wmissing-include-dirs \
2828
-Wpointer-arith \
29-
-Wno-maybe-uninitialized \
30-
-Wno-unused-function \
31-
-Wno-unused-but-set-variable \
32-
-Wno-unused-variable \
33-
-Wno-deprecated-declarations \
34-
-Wno-unused-parameter \
35-
-Wno-unused-but-set-parameter \
36-
-Wno-missing-field-initializers \
37-
-Wno-sign-compare \
3829
-Wno-main
3930

4031

@@ -63,10 +54,12 @@ TGT_AFLAGS = $(TGT_ALLFLAGS)
6354

6455
TGT_LDFLAGS = -nostdlib \
6556
-nostartfiles \
66-
-fno-lto \
57+
-flto \
6758
-e _start \
6859
-Wl,-Map,$(APP).map \
6960
-T $(LINKER_DEFINITION_FILE) \
61+
--specs=nano.specs \
62+
--specs=nosys.specs \
7063
$(TGT_ALLFLAGS)
7164

7265

ref_app/target/micros/xtensa_esp32_s3_riscv_cop/startup/from_no_sdk/Code/Appli/main.cpp

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,22 @@
55
// or copy at http://www.boost.org/LICENSE_1_0.txt)
66
//
77

8-
// Originally from (but strongly mdofied from):
8+
// Originally from (but strongly modified from):
99
/******************************************************************************************
1010
Filename : main.c
11-
11+
1212
Core : RISC-V
13-
13+
1414
MCU : ESP32-S3
15-
15+
1616
Author : Chalandi Amine
17-
17+
1818
Owner : Chalandi Amine
19-
19+
2020
Date : 22.02.2025
21-
21+
2222
Description : Application main function for ULP-RISC-V Co-processor
23-
23+
2424
******************************************************************************************/
2525

2626
#include <mcal_gpt.h>
@@ -46,7 +46,7 @@ namespace
4646
{
4747
using pwm_port_type = mcal::port::port_pin<UINT32_C(17)>;
4848

49-
using pwm_type = mcal::pwm::pwm_port<pwm_port_type, mcal::pwm::pwm_base::duty_type { UINT8_C(256) }>;
49+
using pwm_type = mcal::pwm::pwm_port<pwm_port_type, mcal::pwm::pwm_base::duty_type { UINT16_C(256) }>;
5050

5151
using duty_type = typename pwm_type::duty_type;
5252

@@ -78,6 +78,8 @@ extern "C" auto main() -> int
7878
{
7979
mcal::init();
8080

81+
static_cast<void>(my_pwm.init());
82+
8183
unsigned prescaler { UINT8_C(0) };
8284

8385
for(;;)

ref_app/target/micros/xtensa_esp32_s3_riscv_cop/startup/from_no_sdk/Code/Startup/IntVectTable.S

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// or copy at http://www.boost.org/LICENSE_1_0.txt)
66
//
77
8-
// Originally from:
8+
// Originally from (but strongly modified from):
99
/******************************************************************************************
1010
Filename : IntVectTable.S
1111

ref_app/target/micros/xtensa_esp32_s3_riscv_cop/startup/from_no_sdk/Code/Startup/boot.S

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// or copy at http://www.boost.org/LICENSE_1_0.txt)
66
//
77
8-
// Originally from:
8+
// Originally from (but strongly modified from):
99
/******************************************************************************************
1010
Filename : boot.S
1111

0 commit comments

Comments
 (0)