Skip to content

Improve comments and trivial syntax #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckormanyos merged 1 commit into from
Mar 16, 2025
Merged

Improve comments and trivial syntax #630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ref_app/target/micros/xtensa_esp32_s3/startup/coprocessor_binary.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ coprocessor_bin:
.byte 0x01, 0xA0, 0x00, 0x00, 0x37, 0x15, 0x00, 0x50, 0x13, 0x05, 0x05, 0x0B, 0x82, 0x80, 0x00, 0x00
.byte 0x41, 0x11, 0x06, 0xC6, 0xC5, 0x3F, 0x83, 0x47, 0x05, 0x00, 0x81, 0xE7, 0x85, 0x47, 0x23, 0x00
.byte 0xF5, 0x00, 0xB2, 0x40, 0x41, 0x01, 0x82, 0x80, 0x01, 0x45, 0x81, 0x45, 0x82, 0x80, 0x00, 0x00
.byte 0x82, 0x80, 0x00, 0x00, 0x23, 0x14, 0xB5, 0x00, 0x82, 0x80, 0x00, 0x00, 0x82, 0x80, 0x00, 0x00
.byte 0x05, 0x45, 0x82, 0x80, 0x00, 0x00, 0x00, 0x00, 0xB1, 0x45, 0x09, 0xB7, 0x41, 0x11, 0x01, 0x45
.byte 0x82, 0x80, 0x00, 0x00, 0x05, 0x45, 0x82, 0x80, 0x00, 0x00, 0x00, 0x00, 0x23, 0x14, 0xB5, 0x00
.byte 0x82, 0x80, 0x00, 0x00, 0x82, 0x80, 0x00, 0x00, 0xB1, 0x45, 0x09, 0xB7, 0x41, 0x11, 0x01, 0x45
.byte 0x06, 0xC6, 0xF9, 0x3F, 0xB2, 0x40, 0x01, 0x45, 0x41, 0x01, 0x5D, 0xBF, 0x00, 0x00, 0x00, 0x00
.byte 0x41, 0x11, 0x06, 0xC6, 0xE5, 0x37, 0x37, 0x17, 0x00, 0x50, 0x13, 0x07, 0x47, 0x0B, 0x83, 0x57
.byte 0x67, 0x00, 0x83, 0x55, 0x47, 0x00, 0xB7, 0x1E, 0x00, 0x50, 0xA9, 0x66, 0x37, 0x08, 0x00, 0xF8
Expand Down Expand Up @@ -257,8 +257,8 @@ coprocessor_bin:
.byte 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
.byte 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
.byte 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
.byte 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x3C, 0x01, 0x00, 0x50, 0x48, 0x01, 0x00, 0x50
.byte 0x40, 0x01, 0x00, 0x50, 0x34, 0x01, 0x00, 0x50, 0x01, 0x00, 0x02, 0x00, 0x03, 0x00, 0x04, 0x00
.byte 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x44, 0x01, 0x00, 0x50, 0x48, 0x01, 0x00, 0x50
.byte 0x34, 0x01, 0x00, 0x50, 0x3C, 0x01, 0x00, 0x50, 0x01, 0x00, 0x02, 0x00, 0x03, 0x00, 0x04, 0x00
.byte 0x05, 0x00, 0x06, 0x00, 0x07, 0x00, 0x08, 0x00, 0x09, 0x00, 0x0A, 0x00, 0x0B, 0x00, 0x0C, 0x00
.byte 0x0D, 0x00, 0x0E, 0x00, 0x0F, 0x00, 0x10, 0x00, 0x11, 0x00, 0x12, 0x00, 0x13, 0x00, 0x14, 0x00
.byte 0x15, 0x00, 0x16, 0x00, 0x17, 0x00, 0x18, 0x00, 0x19, 0x00, 0x1A, 0x00, 0x1B, 0x00, 0x1C, 0x00
Expand Down
15 changes: 4 additions & 11 deletions ref_app/target/micros/xtensa_esp32_s3_riscv_cop/make/xtensa_esp32_s3_riscv_cop_flags.gmk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright Christopher Kormanyos 2022 - 2024.
# Copyright Christopher Kormanyos 2022 - 2025.
# Distributed under the Boost Software License,
# Version 1.0. (See accompanying file LICENSE_1_0.txt
# or copy at http://www.boost.org/LICENSE_1_0.txt)
Expand Down Expand Up @@ -26,15 +26,6 @@ WARN_FLAGS := -Wall
-Wunreachable-code \
-Wmissing-include-dirs \
-Wpointer-arith \
-Wno-maybe-uninitialized \
-Wno-unused-function \
-Wno-unused-but-set-variable \
-Wno-unused-variable \
-Wno-deprecated-declarations \
-Wno-unused-parameter \
-Wno-unused-but-set-parameter \
-Wno-missing-field-initializers \
-Wno-sign-compare \
-Wno-main


Expand Down Expand Up @@ -63,10 +54,12 @@ TGT_AFLAGS = $(TGT_ALLFLAGS)

TGT_LDFLAGS = -nostdlib \
-nostartfiles \
-fno-lto \
-flto \
-e _start \
-Wl,-Map,$(APP).map \
-T $(LINKER_DEFINITION_FILE) \
--specs=nano.specs \
--specs=nosys.specs \
$(TGT_ALLFLAGS)


Expand Down
20 changes: 11 additions & 9 deletions ref_app/target/micros/xtensa_esp32_s3_riscv_cop/startup/from_no_sdk/Code/Appli/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,22 @@
// or copy at http://www.boost.org/LICENSE_1_0.txt)
//

// Originally from (but strongly mdofied from):
// Originally from (but strongly modified from):
/******************************************************************************************
Filename : main.c

Core : RISC-V

MCU : ESP32-S3

Author : Chalandi Amine

Owner : Chalandi Amine

Date : 22.02.2025

Description : Application main function for ULP-RISC-V Co-processor

******************************************************************************************/

#include <mcal_gpt.h>
Expand All @@ -46,7 +46,7 @@ namespace
{
using pwm_port_type = mcal::port::port_pin<UINT32_C(17)>;

using pwm_type = mcal::pwm::pwm_port<pwm_port_type, mcal::pwm::pwm_base::duty_type { UINT8_C(256) }>;
using pwm_type = mcal::pwm::pwm_port<pwm_port_type, mcal::pwm::pwm_base::duty_type { UINT16_C(256) }>;

using duty_type = typename pwm_type::duty_type;

Expand Down Expand Up @@ -78,6 +78,8 @@ extern "C" auto main() -> int
{
mcal::init();

static_cast<void>(my_pwm.init());

unsigned prescaler { UINT8_C(0) };

for(;;)
Expand Down
2 changes: 1 addition & 1 deletion ...p/target/micros/xtensa_esp32_s3_riscv_cop/startup/from_no_sdk/Code/Startup/IntVectTable.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// or copy at http://www.boost.org/LICENSE_1_0.txt)
//

// Originally from:
// Originally from (but strongly modified from):
/******************************************************************************************
Filename : IntVectTable.S

Expand Down
2 changes: 1 addition & 1 deletion ref_app/target/micros/xtensa_esp32_s3_riscv_cop/startup/from_no_sdk/Code/Startup/boot.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// or copy at http://www.boost.org/LICENSE_1_0.txt)
//

// Originally from:
// Originally from (but strongly modified from):
/******************************************************************************************
Filename : boot.S

Expand Down