Skip to content

Do some more trivial cleanup #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckormanyos merged 1 commit into from
Feb 15, 2026
Merged

Do some more trivial cleanup #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/chapter11_07a/src/app/pi_calc_cfg.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
///////////////////////////////////////////////////////////////////////////////
// Copyright Christopher Kormanyos 2023 - 2025.
// Copyright Christopher Kormanyos 2023 - 2026.
// Distributed under the Boost Software License,
// Version 1.0. (See accompanying file LICENSE_1_0.txt
// or copy at http://www.boost.org/LICENSE_1_0.txt)
Expand Down
36 changes: 17 additions & 19 deletions ref_app/target/micros/xtensa_esp32_p4/startup/Code/Appli/main_cores.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ extern "C"
auto main_core1() -> void;
}

auto main(void) -> int __attribute__((used,noinline));

namespace local
{
struct timer_core1_backend
Expand All @@ -32,16 +30,6 @@ namespace local

static auto get_now() -> tick_type { return static_cast<tick_type>(mcal::gpt::secure::get_time_elapsed_core1()); }
};

using timer_type = util::timer<std::uint64_t>;

constexpr typename timer_type::tick_type
led_timeout
{
static_cast<typename timer_type::tick_type>(timer_type::seconds(UINT8_C(1)))
};

using timer_core1_type = util::timer<std::uint64_t, timer_core1_backend>;
} // namespace local

extern "C"
Expand All @@ -63,20 +51,30 @@ auto main_core1() -> void

mcal::gpt::init(nullptr);

local::timer_core1_type local_led_timer(local::led_timeout);
using timer_core1_type = util::timer<std::uint64_t, local::timer_core1_backend>;

constexpr typename timer_core1_type::tick_type
led_core1_timeout
{
static_cast<typename timer_core1_type::tick_type>(timer_core1_type::seconds(UINT8_C(1)))
};

timer_core1_type led_core1_timer(led_core1_timeout);

auto& my_led1_core1_ref { mcal::led::led1() };

auto& my_led1_ref { mcal::led::led1() };
my_led1_core1_ref.toggle();

my_led1_ref.toggle();
// Enter an endless LED1 toggle-loop.
// Never return or break.

// Endless LED1 togglee-loop: Never return or break.
for(;;)
{
if(local_led_timer.timeout())
if(led_core1_timer.timeout())
{
my_led1_ref.toggle();
my_led1_core1_ref.toggle();

local_led_timer.start_interval(local::led_timeout);
led_core1_timer.start_interval(led_core1_timeout);
}
}
}
Loading