Skip to content

Fix typos and markdown formatting in examples#733

Merged
ckormanyos merged 5 commits intockormanyos:masterfrom
Alejandro-Casanova:fix-typos-and-md-format-in-examples
Apr 7, 2026
Merged

Fix typos and markdown formatting in examples#733
ckormanyos merged 5 commits intockormanyos:masterfrom
Alejandro-Casanova:fix-typos-and-md-format-in-examples

Conversation

@Alejandro-Casanova
Copy link
Copy Markdown
Contributor

Hi Christopher,

I'm currently reading your book and, first of all, I wanted to thank you for such a valuable contribution. It's been very insightful so far, and I'm really enjoying it.

I've also been going through the companion code examples and noticed some typos. And I thought that, as I'll be going through most of it anyway, I might as well report these to you in the form of a pull request, so you can easily correct them. I hope this doesn't come out as "nitpicky"!

I've also noticed some possible corrections and improvements to the markdown syntax. I usually follow markdownlint rules. As some of these preferences might be subjective, I'm thinking of keeping commits small so any single change can be easily rejected or edited if you see fit.

Please let me know your thoughts on this!

@ckormanyos
Copy link
Copy Markdown
Owner

ckormanyos commented Apr 7, 2026

Hi @Alejandro-Casanova, I'm sorry that I overlooked this PR over the holidays, as this seems to have produced an unfortunate delay.

Thank you, I really appreciate your corrections. I need to approve your CI/CD run (since first-time contributors need approval for CI/CD). It is cycling.

Docs changes usually do not influence CI/CD, but we still need to run it

Let's get this going now.

@ckormanyos
Copy link
Copy Markdown
Owner

The sonar cloud run fails because I never figured out how to let contributors run/use my SONAR TOKEN. I disabled it. It is not truly failing. It is an access rights problem.

@ckormanyos
Copy link
Copy Markdown
Owner

As some of these preferences might be subjective, I'm thinking of keeping commits small so any single change can be easily rejected or edited if you see fit.

So far, good, If you find anything else on the go, please just PR it any time.

@ckormanyos ckormanyos merged commit 30821e6 into ckormanyos:master Apr 7, 2026
148 of 149 checks passed
@ckormanyos
Copy link
Copy Markdown
Owner

Merged. Many thanks @Alejandro-Casanova

@Alejandro-Casanova
Copy link
Copy Markdown
Contributor Author

You're welcome @ckormanyos! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants