Skip to content

Commit f18fb86

Browse files
committed
fix: resolve phpstan matrix failures
1 parent 0fa3b5e commit f18fb86

3 files changed

Lines changed: 12 additions & 17 deletions

File tree

src/DependencyInjection/Compiler/RegisterStampNormalizersPass.php

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
use Symfony\Component\DependencyInjection\Reference;
1414
use Symfony\Component\Messenger\Stamp\StampInterface;
1515

16-
use function array_unique;
1716
use function array_values;
1817
use function is_string;
1918

@@ -88,15 +87,14 @@ private function supportedStampClasses(ContainerBuilder $container, string $serv
8887

8988
$this->assertNormalizerClass($class);
9089

91-
$stampClasses = [];
90+
/** @var array<class-string<StampInterface>, class-string<StampInterface>> $uniqueStampClasses */
91+
$uniqueStampClasses = [];
9292

9393
foreach ($tags as $tag) {
94-
$stampClasses[] = isset($tag['stamp_class'])
94+
$stampClass = isset($tag['stamp_class'])
9595
? $tag['stamp_class']
9696
: $class::getSupportedStampClass();
97-
}
9897

99-
foreach ($stampClasses as $stampClass) {
10098
if (!is_string($stampClass)) {
10199
throw new InvalidArgumentException(sprintf(
102100
'Stamp normalizer service "%s" must declare stamp classes as strings.',
@@ -105,16 +103,13 @@ private function supportedStampClasses(ContainerBuilder $container, string $serv
105103
}
106104

107105
$this->assertStampClass($stampClass);
108-
}
109-
110-
$uniqueStampClasses = [];
111-
112-
foreach ($stampClasses as $stampClass) {
113106
$uniqueStampClasses[$stampClass] = $stampClass;
114107
}
115108

116-
/** @var list<class-string<StampInterface>> */
117-
return array_values($uniqueStampClasses);
109+
/** @var list<class-string<StampInterface>> $supportedStampClasses */
110+
$supportedStampClasses = array_values($uniqueStampClasses);
111+
112+
return $supportedStampClasses;
118113
}
119114

120115
private function assertStampClass(string $stampClass): void

src/Logging/MessengerLogContextBuilder.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,7 @@ final class MessengerLogContextBuilder
4444
public function __construct(
4545
ServiceProviderInterface|null $stampNormalizers = null,
4646
) {
47-
/** @var ServiceProviderInterface<StampNormalizerInterface> $resolvedStampNormalizers */
48-
$resolvedStampNormalizers = $stampNormalizers ?? new ServiceLocator([]);
49-
50-
$this->stampNormalizers = $resolvedStampNormalizers;
47+
$this->stampNormalizers = $stampNormalizers ?? new ServiceLocator([]);
5148
}
5249

5350
public function withUuid(Envelope $envelope): Envelope

tests/Fixtures/MonologTestLoggerTrait.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ private function lastRecord(TestHandler $handler): LogRecord
2626
$records = $handler->getRecords();
2727
Assert::assertNotSame([], $records, 'No log records captured.');
2828

29-
return $records[array_key_last($records)];
29+
$lastKey = array_key_last($records);
30+
Assert::assertNotNull($lastKey);
31+
32+
return $records[$lastKey];
3033
}
3134
}

0 commit comments

Comments
 (0)