Add abstract coroutine class and have ImplBase extend it#1
Open
cengdall-blaze wants to merge 1 commit into
Open
Add abstract coroutine class and have ImplBase extend it#1cengdall-blaze wants to merge 1 commit into
ImplBase extend it#1cengdall-blaze wants to merge 1 commit into
Conversation
Spring application is failing to start when bindService is final: ``` WARN: Unable to proxy interface-implementing method [public final io.grpc.ServerServiceDefinition com.backblaze.ServiceImplBase.bindService()] because it is marked as final, consider using interface-based JDK proxies instead. ``` CGLIB proxies are required to apply Spring AOP to grpc service implementations if there isn't an interface. Wire's output (as well as that of gprc-java) generates an abstract class, so Spring is attempting to generate CGLIB proxies and failing due to not being able to override the bindService method. This change hsa `ImplBase` extend an abstract class when generating suspending calls, which itself implements `WireBindableService`. This is a similar pattern to what is being done by grpc-java.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spring application is failing to start when bindService is final:
CGLIB proxies are required to apply Spring AOP to grpc service implementations if there isn't an interface. Wire's output (as well as that of gprc-java) generates an abstract class, so Spring is attempting to generate CGLIB proxies and failing due to not being able to override the
bindServicemethod.This change has
ImplBaseextend an abstract class when generating suspending calls, which itself implementsWireBindableService. This is a similar pattern to what is being done by grpc-java.