Skip to content

feat: Add support for Alma Linux #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HighCommander4 merged 4 commits into from
Feb 9, 2026
Merged

feat: Add support for Alma Linux #60

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f424606
feat: Add support for Alma Linux
mancasg Feb 6, 2026
1e547cc
Fix glibc regex
mancasg Feb 7, 2026
8eddaa6
Use non capturing group during ldd version match
mancasg Feb 8, 2026
c34ca62
Get formatter check to pass
HighCommander4 Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,9 +439,11 @@ namespace Version {
const line = output.split('\n', 1)[0];
// Require some confirmation this is [e]glibc, and a plausible

@HighCommander4 HighCommander4 Feb 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, the [e] here was deliberate, it's a reference to https://github.com/Xilinx/eglibc, please keep it

@mancasg mancasg Feb 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The irony is that just earlier I referenced Chesterton's fence

// version number.
const match = line.match(/^ldd .*glibc.* (\d+(?:\.\d+)+)[^ ]*$/i);
const match = line.match(/^ldd .*(?:GNU |g)libc.* (\d+(?:\.\d+)+)[^ ]*$/i);
if (!match || !semver.validRange(match[1], loose)) {
console.error(`Can't glibc version from ldd --version output: ${line}`);
console.error(
`Can't determine glibc version from ldd --version output: ${line}`,
);
return null;
}
const version = new semver.Range(match[1], loose);
Expand Down