Skip to content

Commit 5b4684d

Browse files
Update - use ///TODO:
1 parent 02599ef commit 5b4684d

28 files changed

Lines changed: 45 additions & 38 deletions

Marlin/src/HAL/GD32_MFL/temp_soc.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,5 @@
2525
#define TS_TYPICAL_TEMP 25
2626
#define TS_TYPICAL_SLOPE 4.5
2727

28-
// TODO: Implement voltage scaling (calibrated Vrefint) and ADC resolution scaling (when applicable)
28+
/// TODO: Implement voltage scaling (calibrated Vrefint) and ADC resolution scaling (when applicable)
2929
#define TEMP_SOC_SENSOR(RAW) ((TS_TYPICAL_V - (RAW) / float(OVERSAMPLENR) / float(HAL_ADC_RANGE) * (float(ADC_VREF_MV) * 0.001f)) / ((TS_TYPICAL_SLOPE) * 0.001f) + TS_TYPICAL_TEMP)

Marlin/src/HAL/HC32/MarlinHAL.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ void MarlinHAL::set_pwm_duty(const pin_t pin, const uint16_t value, const uint16
300300
}
301301

302302
void MarlinHAL::set_pwm_frequency(const pin_t pin, const uint16_t f_desired) {
303-
// TODO set_pwm_frequency is not implemented yet
303+
/// TODO: set_pwm_frequency is not implemented yet
304304
panic("set_pwm_frequency is not implemented yet\n");
305305
}
306306

Marlin/src/HAL/HC32/MarlinSerial.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ constexpr bool serial_handles_emergency(int port) {
7070
DEFINE_SERIAL_MARLIN(MSerial1, 1);
7171
DEFINE_SERIAL_MARLIN(MSerial2, 2);
7272

73-
// TODO: remove this warning when SERIAL_DMA has been tested some more
73+
/// TODO: remove this warning when SERIAL_DMA has been tested some more
7474
#if ENABLED(SERIAL_DMA)
7575
#warning "SERIAL_DMA may be unstable on HC32F460."
7676
#endif

Marlin/src/HAL/HC32/MinSerial.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ static void minserial_begin() {
6464
// keeping the dynamic baudrate would require re-calculating the baudrate
6565
// using the register values, which is a pain...
6666

67-
// TODO: retain dynamic baudrate in MinSerial init
67+
/// TODO: retain dynamic baudrate in MinSerial init
6868
// -> see USART_SetBaudrate(), needs to be inverted
6969
USART_SYNC_INIT(SERIAL_PORT, BAUDRATE, &usart_config);
7070

Marlin/src/HAL/HC32/sysclock.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ void core_hook_sysclock_init() {
166166
sysclock_configure_hrc();
167167

168168
// HRC could have been configured by ICG to 20 MHz
169-
// TODO: handle gracefully if HRC is not 16 MHz
169+
/// TODO: handle gracefully if HRC is not 16 MHz
170170
if (1UL != (HRC_FREQ_MON() & 1UL)) {
171171
panic("HRC is not 16 MHz");
172172
}

Marlin/src/HAL/SAMD21/pinsDebug.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ bool getValidPinMode(const int8_t pin) { // 1: output, 0: input
6666

6767
void printPinPWM(const int32_t pin) {
6868
if (pwm_status(pin)) {
69-
//uint32_t chan = g_APinDescription[pin].ulPWMChannel TODO when fast pwm is operative;
69+
//uint32_t chan = g_APinDescription[pin].ulPWMChannel
70+
/// TODO: when fast pwm is operative;
7071
//SERIAL_ECHOPGM("PWM = ", duty);
7172
}
7273
}

Marlin/src/HAL/STM32/sd/msc_sd.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
class Sd2CardUSBMscHandler : public USBMscHandler {
4949
public:
5050
DiskIODriver* diskIODriver() {
51-
// TODO: Explore a variable shared volume, or auto share the un-mounted volume(s)
51+
/// TODO: Explore a variable shared volume, or auto share the un-mounted volume(s)
5252
#if HAS_MULTI_VOLUME
5353
#if SHARED_VOLUME_IS(SD_ONBOARD)
5454
return &card.media_driver_sdcard;

Marlin/src/HAL/STM32/temp_soc.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@
326326
#define TS_CAL2_REGOFFSET 0x1FFF75CA
327327
#endif
328328

329-
// TODO implement voltage scaling (calibrated Vrefint) and ADC resolution scaling (when applicable)
329+
/// TODO: implement voltage scaling (calibrated Vrefint) and ADC resolution scaling (when applicable)
330330

331331
/**
332332
* When provided in datasheet, the use of calibrated values (TS_CAL1, TS_CAL2) should always be preferred over typical values.

Marlin/src/HAL/STM32F1/HAL.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,8 @@ void MarlinHAL::idletask() {
293293
* command so drives can be released as needed.
294294
*/
295295
/* Copied from LPC1768 framework. Should be fixed later to process HAS_SD_HOST_DRIVE */
296-
//if (!drive_locked()) // TODO
296+
//if (!drive_locked())
297+
/// TODO:
297298
MarlinMSC.loop(); // Process USB mass storage device class loop
298299
#endif
299300
}

Marlin/src/HAL/STM32F1/timers.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ timer_dev* HAL_get_timer_dev(int number);
120120

121121
#define HAL_timer_get_count(timer_num) timer_get_count(TIMER_DEV(timer_num))
122122

123-
// TODO change this
123+
/// TODO: change this
124124

125125
#ifndef HAL_TEMP_TIMER_ISR
126126
#define HAL_TEMP_TIMER_ISR() extern "C" void tempTC_Handler()

0 commit comments

Comments
 (0)