claude-code-best
diff --git a/‎docs/memory-leak-audit.md‎
Lines changed: 659 additions & 0 deletions b/‎docs/memory-leak-audit.md‎
Lines changed: 659 additions & 0 deletions
diff --git a/‎packages/color-diff-napi/src/__tests__/language-registration.test.ts‎
Lines changed: 71 additions & 0 deletions b/‎packages/color-diff-napi/src/__tests__/language-registration.test.ts‎
Lines changed: 71 additions & 0 deletions
diff --git a/‎packages/color-diff-napi/src/index.ts‎
Lines changed: 64 additions & 7 deletions b/‎packages/color-diff-napi/src/index.ts‎
Lines changed: 64 additions & 7 deletions
diff --git a/‎src/hooks/__tests__/replBridgePermissionHandlers.test.ts‎
Lines changed: 114 additions & 0 deletions b/‎src/hooks/__tests__/replBridgePermissionHandlers.test.ts‎
Lines changed: 114 additions & 0 deletions
diff --git a/‎src/hooks/__tests__/swarmPermissionPoller.test.ts‎
Lines changed: 107 additions & 0 deletions b/‎src/hooks/__tests__/swarmPermissionPoller.test.ts‎
Lines changed: 107 additions & 0 deletions
@@ -0,0 +1,71 @@
+import { describe, expect, test } from 'bun:test'
+import hljs from 'highlight.js/lib/core'
+
+// Re-import the module to trigger language registration side effects
+// The module-level registerLanguage calls happen on import
+import '../index.js'
+
+describe('highlight.js language registration', () => {
+  const expectedLanguages = [
+    'bash', 'c', 'cmake', 'cpp', 'csharp', 'css', 'diff', 'dockerfile',
+    'go', 'graphql', 'java', 'javascript', 'json', 'kotlin', 'makefile',
+    'markdown', 'perl', 'php', 'python', 'ruby', 'rust', 'shell', 'sql',
+    'typescript', 'xml', 'yaml',
+  ]
+
+  test('all expected languages are registered', () => {
+    for (const lang of expectedLanguages) {
+      expect(hljs.getLanguage(lang)).toBeDefined()
+    }
+  })
+
+  test('unregistered language returns undefined', () => {
+    expect(hljs.getLanguage('totally-not-a-real-language-xyz')).toBeUndefined()
+  })
+
+  test('highlight works for TypeScript', () => {
+    const result = hljs.highlight('const x: number = 42', {
+      language: 'typescript',
+      ignoreIllegals: true,
+    })
+    expect(result.value).toContain('const')
+    expect(result.language).toBe('typescript')
+  })
+
+  test('highlight works for Python', () => {
+    const result = hljs.highlight('def hello():\n    print("hi")', {
+      language: 'python',
+      ignoreIllegals: true,
+    })
+    expect(result.value).toContain('def')
+    expect(result.language).toBe('python')
+  })
+
+  test('highlight works for JSON', () => {
+    const result = hljs.highlight('{"key": "value"}', {
+      language: 'json',
+      ignoreIllegals: true,
+    })
+    expect(result.language).toBe('json')
+  })
+
+  test('highlight works for Bash', () => {
+    const result = hljs.highlight('echo "hello world"', {
+      language: 'bash',
+      ignoreIllegals: true,
+    })
+    expect(result.language).toBe('bash')
+  })
+
+  test('all expected languages are registered (standalone)', () => {
+    // When running standalone, only 26 languages are registered via index.ts.
+    // When running in the full test suite, cliHighlight.ts imports the full
+    // highlight.js bundle (190+ languages) which shares the same core singleton,
+    // so the total count is higher. We verify our 26 languages are present regardless.
+    const registered = hljs.listLanguages()
+    for (const lang of expectedLanguages) {
+      expect(registered).toContain(lang)
+    }
+    expect(registered.length).toBeGreaterThanOrEqual(expectedLanguages.length)
+  })
+})
@@ -18,19 +18,76 @@
  */
 
 import { diffArrays } from 'diff'
-import hljs from 'highlight.js'
+// Import the minimal highlight.js core (no languages) instead of the full
+// bundle that loads 190+ grammars (~5-15MB). Individual languages are
+// imported statically below and registered on the core instance. Static
+// imports work in Bun --compile mode (only createRequire fails).
+import hljs from 'highlight.js/lib/core'
 import { basename, extname } from 'path'
 
-// Static import — createRequire(import.meta.url) fails in Bun --compile mode
-// because the resolved path points to the internal bunfs binary path where
-// node_modules cannot be found. A top-level import ensures the module is
-// bundled and accessible at runtime.
+// --- Register commonly-used languages (~25 instead of 190+) ---
+import langBash from 'highlight.js/lib/languages/bash'
+import langC from 'highlight.js/lib/languages/c'
+import langCmake from 'highlight.js/lib/languages/cmake'
+import langCpp from 'highlight.js/lib/languages/cpp'
+import langCsharp from 'highlight.js/lib/languages/csharp'
+import langCss from 'highlight.js/lib/languages/css'
+import langDiff from 'highlight.js/lib/languages/diff'
+import langDockerfile from 'highlight.js/lib/languages/dockerfile'
+import langGo from 'highlight.js/lib/languages/go'
+import langGraphQL from 'highlight.js/lib/languages/graphql'
+import langJava from 'highlight.js/lib/languages/java'
+import langJavaScript from 'highlight.js/lib/languages/javascript'
+import langJson from 'highlight.js/lib/languages/json'
+import langKotlin from 'highlight.js/lib/languages/kotlin'
+import langMakefile from 'highlight.js/lib/languages/makefile'
+import langMarkdown from 'highlight.js/lib/languages/markdown'
+import langPerl from 'highlight.js/lib/languages/perl'
+import langPhp from 'highlight.js/lib/languages/php'
+import langPython from 'highlight.js/lib/languages/python'
+import langRuby from 'highlight.js/lib/languages/ruby'
+import langRust from 'highlight.js/lib/languages/rust'
+import langShell from 'highlight.js/lib/languages/shell'
+import langSql from 'highlight.js/lib/languages/sql'
+import langTypeScript from 'highlight.js/lib/languages/typescript'
+import langXml from 'highlight.js/lib/languages/xml'
+import langYaml from 'highlight.js/lib/languages/yaml'
+
+hljs.registerLanguage('bash', langBash)
+hljs.registerLanguage('c', langC)
+hljs.registerLanguage('cmake', langCmake)
+hljs.registerLanguage('cpp', langCpp)
+hljs.registerLanguage('csharp', langCsharp)
+hljs.registerLanguage('css', langCss)
+hljs.registerLanguage('diff', langDiff)
+hljs.registerLanguage('dockerfile', langDockerfile)
+hljs.registerLanguage('go', langGo)
+hljs.registerLanguage('graphql', langGraphQL)
+hljs.registerLanguage('java', langJava)
+hljs.registerLanguage('javascript', langJavaScript)
+hljs.registerLanguage('json', langJson)
+hljs.registerLanguage('kotlin', langKotlin)
+hljs.registerLanguage('makefile', langMakefile)
+hljs.registerLanguage('markdown', langMarkdown)
+hljs.registerLanguage('perl', langPerl)
+hljs.registerLanguage('php', langPhp)
+hljs.registerLanguage('python', langPython)
+hljs.registerLanguage('ruby', langRuby)
+hljs.registerLanguage('rust', langRust)
+hljs.registerLanguage('shell', langShell)
+hljs.registerLanguage('sql', langSql)
+hljs.registerLanguage('typescript', langTypeScript)
+hljs.registerLanguage('xml', langXml)
+hljs.registerLanguage('yaml', langYaml)
+// JavaScript grammar also handles .mjs/.cjs extensions
+// TypeScript grammar also handles .tsx via auto-detection
+
 type HLJSApi = typeof hljs
 let cachedHljs: HLJSApi | null = null
 function hljsApi(): HLJSApi {
   if (cachedHljs) return cachedHljs
-  // highlight.js uses `export =` (CJS). Under bun/ESM the interop wraps it
-  // in .default; under node CJS the module IS the API. Check at runtime.
+  // highlight.js/lib/core uses `export =` (CJS). Under bun/ESM the interop
+  // wraps it in .default; under node CJS the module IS the API. Check at runtime.
   const mod = hljs as HLJSApi & { default?: HLJSApi }
   cachedHljs = 'default' in mod && mod.default ? mod.default : mod
   return cachedHljs!
 
@@ -0,0 +1,114 @@
+import { describe, expect, test } from 'bun:test'
+
+/**
+ * Tests for the pendingPermissionHandlers cleanup pattern used in
+ * useReplBridge.tsx. The handlers Map tracks in-flight permission
+ * requests; the cleanup function must clear it on unmount to release
+ * closures that capture React state.
+ *
+ * The actual hook is deeply integrated with React/bridge lifecycle,
+ * so these tests validate the Map management pattern in isolation.
+ */
+
+type PermissionHandler = (response: { approved: boolean }) => void
+
+function createPermissionHandlersMap() {
+  const handlers = new Map<string, PermissionHandler>()
+
+  return {
+    handlers,
+    onResponse(requestId: string, handler: PermissionHandler): () => void {
+      handlers.set(requestId, handler)
+      return () => {
+        handlers.delete(requestId)
+      }
+    },
+    handleResponse(requestId: string, response: { approved: boolean }): boolean {
+      const handler = handlers.get(requestId)
+      if (!handler) return false
+      handlers.delete(requestId)
+      handler(response)
+      return true
+    },
+    cleanup(): void {
+      handlers.clear()
+    },
+    size(): number {
+      return handlers.size
+    },
+  }
+}
+
+describe('pendingPermissionHandlers cleanup pattern', () => {
+  test('onResponse registers a handler', () => {
+    const map = createPermissionHandlersMap()
+    map.onResponse('req-1', () => {})
+    expect(map.size()).toBe(1)
+  })
+
+  test('onResponse returns a cancel function', () => {
+    const map = createPermissionHandlersMap()
+    const cancel = map.onResponse('req-1', () => {})
+    expect(map.size()).toBe(1)
+    cancel()
+    expect(map.size()).toBe(0)
+  })
+
+  test('handleResponse dispatches to handler and removes it', () => {
+    const map = createPermissionHandlersMap()
+    let received: { approved: boolean } | null = null
+    map.onResponse('req-1', (resp) => { received = resp })
+    const dispatched = map.handleResponse('req-1', { approved: true })
+    expect(dispatched).toBe(true)
+    expect(received as unknown as { approved: boolean }).toEqual({ approved: true })
+    expect(map.size()).toBe(0)
+  })
+
+  test('handleResponse returns false for unknown requestId', () => {
+    const map = createPermissionHandlersMap()
+    const dispatched = map.handleResponse('unknown', { approved: true })
+    expect(dispatched).toBe(false)
+  })
+
+  test('cleanup clears all registered handlers', () => {
+    const map = createPermissionHandlersMap()
+    map.onResponse('req-1', () => {})
+    map.onResponse('req-2', () => {})
+    map.onResponse('req-3', () => {})
+    expect(map.size()).toBe(3)
+
+    map.cleanup()
+
+    expect(map.size()).toBe(0)
+  })
+
+  test('handlers are not dispatched after cleanup', () => {
+    const map = createPermissionHandlersMap()
+    let called = false
+    map.onResponse('req-1', () => { called = true })
+
+    map.cleanup()
+
+    // Late-arriving response after cleanup should not find a handler
+    const dispatched = map.handleResponse('req-1', { approved: true })
+    expect(dispatched).toBe(false)
+    expect(called).toBe(false)
+  })
+
+  test('cancel function is a no-op after cleanup', () => {
+    const map = createPermissionHandlersMap()
+    const cancel = map.onResponse('req-1', () => {})
+    map.cleanup()
+    // Should not throw
+    expect(() => cancel()).not.toThrow()
+  })
+
+  test('cleanup can be called multiple times safely', () => {
+    const map = createPermissionHandlersMap()
+    map.onResponse('req-1', () => {})
+    map.cleanup()
+    map.cleanup()
+    map.cleanup()
+    expect(map.size()).toBe(0)
+  })
+})
@@ -0,0 +1,107 @@
+import { afterEach, describe, expect, test } from 'bun:test'
+import {
+  hasPermissionCallback,
+  processMailboxPermissionResponse,
+  registerPermissionCallback,
+  clearAllPendingCallbacks,
+  unregisterPermissionCallback,
+} from '../../hooks/useSwarmPermissionPoller.js'
+
+afterEach(() => {
+  clearAllPendingCallbacks()
+})
+
+describe('swarm permission poller registry', () => {
+  test('register and unregister callback', () => {
+    registerPermissionCallback({
+      requestId: 'req-1',
+      toolUseId: 'tool-1',
+      onAllow: () => {},
+      onReject: () => {},
+    })
+    expect(hasPermissionCallback('req-1')).toBe(true)
+    unregisterPermissionCallback('req-1')
+    expect(hasPermissionCallback('req-1')).toBe(false)
+  })
+
+  test('processMailboxPermissionResponse removes callback on approve', () => {
+    let approved = false
+    registerPermissionCallback({
+      requestId: 'req-2',
+      toolUseId: 'tool-2',
+      onAllow: () => { approved = true },
+      onReject: () => {},
+    })
+    const result = processMailboxPermissionResponse({
+      requestId: 'req-2',
+      decision: 'approved',
+    })
+    expect(result).toBe(true)
+    expect(approved).toBe(true)
+    // Callback is removed after processing
+    expect(hasPermissionCallback('req-2')).toBe(false)
+  })
+
+  test('processMailboxPermissionResponse removes callback on reject', () => {
+    let rejected = false
+    registerPermissionCallback({
+      requestId: 'req-3',
+      toolUseId: 'tool-3',
+      onAllow: () => {},
+      onReject: () => { rejected = true },
+    })
+    const result = processMailboxPermissionResponse({
+      requestId: 'req-3',
+      decision: 'rejected',
+      feedback: 'denied',
+    })
+    expect(result).toBe(true)
+    expect(rejected).toBe(true)
+    expect(hasPermissionCallback('req-3')).toBe(false)
+  })
+
+  test('processMailboxPermissionResponse returns false for unknown request', () => {
+    const result = processMailboxPermissionResponse({
+      requestId: 'unknown',
+      decision: 'approved',
+    })
+    expect(result).toBe(false)
+  })
+
+  test('resetPermissionCallbacks clears all callbacks', () => {
+    registerPermissionCallback({
+      requestId: 'req-a',
+      toolUseId: 'tool-a',
+      onAllow: () => {},
+      onReject: () => {},
+    })
+    registerPermissionCallback({
+      requestId: 'req-b',
+      toolUseId: 'tool-b',
+      onAllow: () => {},
+      onReject: () => {},
+    })
+    clearAllPendingCallbacks()
+    expect(hasPermissionCallback('req-a')).toBe(false)
+    expect(hasPermissionCallback('req-b')).toBe(false)
+  })
+
+  test('callback is removed BEFORE invoking handler (prevents re-entrant leak)', () => {
+    const order: string[] = []
+    registerPermissionCallback({
+      requestId: 'req-order',
+      toolUseId: 'tool-order',
+      onAllow: () => {
+        // During callback execution, the callback should already be removed
+        order.push('callback')
+        order.push(`has:${hasPermissionCallback('req-order')}`)
+      },
+      onReject: () => {},
+    })
+    processMailboxPermissionResponse({
+      requestId: 'req-order',
+      decision: 'approved',
+    })
+    expect(order).toEqual(['callback', 'has:false'])
+  })
+})