feat: add China LLM providers guided login flow#1254
Open
YuanyuanMa03 wants to merge 5 commits into
Open
Conversation
Add a guided login experience for 4 domestic (China) LLM providers in the /login command: DeepSeek, Zhipu GLM, Tongyi Qianwen, and MiMo Xiaomi. Each provider includes model presets with pricing, context windows, and optional Coding Plan integration. - New file: src/utils/chinaLlmProviders.ts — provider preset configs - Modified: src/components/ConsoleOAuthFlow.tsx — 4-step guided flow (select provider → select mode → select model → enter API key) All providers are OpenAI-compatible; credentials saved as OPENAI_BASE_URL + OPENAI_API_KEY under modelType: 'openai'. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR adds China LLM provider support to the OAuth flow. It introduces a new utility module defining provider types and presets (including URLs and pricing), then integrates a four-step provider setup flow into the existing OAuth component for provider, mode, model, and API key selection. ChangesChina LLM Providers OAuth Integration
Sequence Diagram(s)sequenceDiagram
participant ConsoleOAuthFlow
participant resolveChinaProviderBaseURL
participant SettingsService
participant process_env
participant Analytics
ConsoleOAuthFlow->>resolveChinaProviderBaseURL: resolveChinaProviderBaseURL(providerId, mode)
ConsoleOAuthFlow->>SettingsService: updateSettingsForSource('userSettings', { modelType: 'openai', env })
SettingsService->>process_env: mirror env into process.env
ConsoleOAuthFlow->>Analytics: analytics.logEvent('china_login_success', ...)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
src/components/ConsoleOAuthFlow.tsx (2)
22-22: ⚡ Quick winUse the
src/*alias for the new provider import.This adds another relative import inside
src/, which goes against the repo import-path rule and makes future file moves harder.Suggested change
-import { CHINA_LLM_PROVIDERS, type ProviderPreset, resolveChinaProviderBaseURL } from '../utils/chinaLlmProviders.js'; +import { + CHINA_LLM_PROVIDERS, + type ProviderPreset, + resolveChinaProviderBaseURL, +} from 'src/utils/chinaLlmProviders.js';As per coding guidelines "Import paths must use the
src/*alias (e.g.,import { ... } from 'src/utils/...'); tsconfig mapssrc/*to./src/*."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/ConsoleOAuthFlow.tsx` at line 22, Replace the relative import in ConsoleOAuthFlow.tsx with the repo alias import: update the import that currently pulls CHINA_LLM_PROVIDERS, ProviderPreset, and resolveChinaProviderBaseURL via a relative path to use the src/* alias (e.g., import { CHINA_LLM_PROVIDERS, type ProviderPreset, resolveChinaProviderBaseURL } from 'src/utils/chinaLlmProviders.js') so the module resolution follows the tsconfig mapping and avoids future breakage when files move.
1425-1428: ⚡ Quick winDon't reintroduce
as anyin the newsrc/save path.The China flow bypasses the settings payload type right at the persistence boundary.
doOpenAISavein this same file already shows the typed pattern to reuse here.As per coding guidelines "Do not use
as anyin production code; useas unknown as SpecificTypefor double assertions or use proper interface definitions."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/ConsoleOAuthFlow.tsx` around lines 1425 - 1428, The call to updateSettingsForSource in ConsoleOAuthFlow.tsx is bypassing types with "as any"; replace that with the same typed pattern used by doOpenAISave: construct a properly typed payload (or cast via as unknown as YourSettingsType) and pass that instead of using "as any", referencing updateSettingsForSource and doOpenAISave to mirror the typed save path and ensure the modelType/env object conforms to the expected settings interface.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/ConsoleOAuthFlow.tsx`:
- Around line 1418-1437: The saved env is merged so an existing OPENAI_AUTH_MODE
can persist; when switching to provider API keys you must explicitly clear it:
add OPENAI_AUTH_MODE: undefined to the env object you pass into
updateSettingsForSource (the env declared before the call to
updateSettingsForSource) so persisted settings remove that key, and after a
successful save also delete process.env.OPENAI_AUTH_MODE (or set it to
undefined) in the success branch where you copy env into process.env to ensure
the in-memory env is cleared as well.
- Around line 1456-1459: The help text always uses provider.apiKeyPage and
provider.keyFormat which is wrong for coding-plan providers (e.g., Qwen, MiMo);
update the rendering in ConsoleOAuthFlow.tsx so the Text nodes that currently
reference provider.apiKeyPage and provider.keyFormat instead first check for and
use the coding-plan metadata for the selected provider (e.g., locate the
provider's plan with id 'coding-plan' or a codingPlan/metadata field on the
provider and read its apiKeyPage/keyFormat) and only fall back to
provider.apiKeyPage/provider.keyFormat if that metadata is absent; update the
three Text lines near the Box flexDirection="column" block to prefer coding-plan
metadata to ensure correct key page and format are shown.
---
Nitpick comments:
In `@src/components/ConsoleOAuthFlow.tsx`:
- Line 22: Replace the relative import in ConsoleOAuthFlow.tsx with the repo
alias import: update the import that currently pulls CHINA_LLM_PROVIDERS,
ProviderPreset, and resolveChinaProviderBaseURL via a relative path to use the
src/* alias (e.g., import { CHINA_LLM_PROVIDERS, type ProviderPreset,
resolveChinaProviderBaseURL } from 'src/utils/chinaLlmProviders.js') so the
module resolution follows the tsconfig mapping and avoids future breakage when
files move.
- Around line 1425-1428: The call to updateSettingsForSource in
ConsoleOAuthFlow.tsx is bypassing types with "as any"; replace that with the
same typed pattern used by doOpenAISave: construct a properly typed payload (or
cast via as unknown as YourSettingsType) and pass that instead of using "as
any", referencing updateSettingsForSource and doOpenAISave to mirror the typed
save path and ensure the modelType/env object conforms to the expected settings
interface.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 91a46235-d775-4aa1-9dc9-e8cedb4c4947
📒 Files selected for processing (2)
src/components/ConsoleOAuthFlow.tsxsrc/utils/chinaLlmProviders.ts
Owner
|
@YuanyuanMa03 有验证截图么 |
Contributor
Author
|
Contributor
Author
|
Contributor
Author
|
Contributor
Author
|
但是我不确定这种方式好不好，因为是编码了模型名称，后面如果有新的模型，需要迭代。 |
Owner
|
问题不大， 你支持一下用户重新声明名称呗 @YuanyuanMa03 |
Contributor
Author
|
OK好的 |
Contributor
Author
|
已实现自定义模型名称功能，改动如下： 模型选择页
自定义模型输入
已知模型列表链接
同时修复 CodeRabbit review 的问题
|
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/logincommand: DeepSeek, Zhipu GLM, Tongyi Qianwen, and MiMo XiaomiOPENAI_BASE_URL+OPENAI_API_KEYundermodelType: 'openai'New file
src/utils/chinaLlmProviders.ts— Provider preset configurations with types, model data, pricing, and helper functionsModified file
src/components/ConsoleOAuthFlow.tsx— Added 4-step guided flow:Providers
Test plan
/loginand verify "China LLM Providers" option appears in the menubun run precheck— all checks pass🤖 Generated with Claude Code
Summary by CodeRabbit