feat: fork-agent-redesign — 新增 AgentTool fork 参数与 spec 设计文档 #405
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| import { describe, expect, test } from 'bun:test' | ||
| import { readFileSync } from 'fs' | ||
| import { join, dirname } from 'path' | ||
| import { fileURLToPath } from 'url' | ||
|
|
||
| const __dirname = dirname(fileURLToPath(import.meta.url)) | ||
| const promptSource = readFileSync(join(__dirname, '..', 'prompt.ts'), 'utf-8') | ||
|
|
||
| describe('prompt.ts fork-related text verification', () => { | ||
| test('does not contain "omit `subagent_type`" guidance', () => { | ||
| expect(promptSource).not.toMatch(/omit.*subagent_type/) | ||
| }) | ||
|
|
||
| test('contains `fork: true` in at least 3 locations (shared + whenToFork + forkExamples)', () => { | ||
| const matches = promptSource.match(/fork: true/g) | ||
| expect(matches).not.toBeNull() | ||
| expect(matches!.length).toBeGreaterThanOrEqual(3) | ||
| }) | ||
|
|
||
| test('all forkEnabled references are ternary conditions, not negated', () => { | ||
| const lines = promptSource.split('\n') | ||
| for (const line of lines) { | ||
| if ( | ||
| line.includes('forkEnabled') && | ||
| !line.includes('const forkEnabled') && | ||
| !line.includes('forkEnabled =') | ||
| ) { | ||
| expect(line).not.toContain('!forkEnabled') | ||
| } | ||
| } | ||
| }) | ||
|
|
||
| test('uses "non-fork" terminology instead of "fresh agent"', () => { | ||
| expect(promptSource).toContain('non-fork') | ||
| // "fresh agent" should not appear in fork-aware conditional text | ||
| const freshAgentMatches = promptSource.match(/fresh agent/g) | ||
| if (freshAgentMatches) { | ||
| // Only allowed in comments explaining behavior, not in prompt text | ||
| const linesWithFreshAgent = promptSource | ||
| .split('\n') | ||
| .filter(line => line.includes('fresh agent')) | ||
| .map(line => line.trim()) | ||
| for (const line of linesWithFreshAgent) { | ||
| // "fresh agent" in the context of "starts fresh" (not fork-aware) is ok | ||
| // but "fresh agent" in forkEnabled conditional should not appear | ||
| expect(line).not.toMatch(/fresh agent.*subagent_type/) | ||
| } | ||
| } | ||
| }) | ||
|
|
||
| test('background task condition does not include !forkEnabled', () => { | ||
| // The condition for showing background task instructions should not exclude fork | ||
| const bgCondition = promptSource.match( | ||
| /!isEnvTruthy.*isInProcessTeammate[\s\S]*?run_in_background/, | ||
| ) | ||
| if (bgCondition) { | ||
| expect(bgCondition[0]).not.toContain('!forkEnabled') | ||
| } | ||
| }) | ||
|
Comment on lines
+51
to
+59
Contributor
There was a problem hiding this comment. Fail if the background-note block disappears. If Suggested fix test('background task condition does not include !forkEnabled', () => {
// The condition for showing background task instructions should not exclude fork
const bgCondition = promptSource.match(
/!isEnvTruthy.*isInProcessTeammate[\s\S]*?run_in_background/,
)
- if (bgCondition) {
- expect(bgCondition[0]).not.toContain('!forkEnabled')
- }
+ expect(bgCondition).not.toBeNull()
+ expect(bgCondition![0]).not.toContain('!forkEnabled')
})🤖 Prompt for AI Agents |
||
|
|
||
| test('fork example includes fork: true parameter', () => { | ||
| // The first fork example should have fork: true | ||
| const forkExampleBlock = promptSource.match( | ||
| /name: "ship-audit"[\s\S]*?Under 200 words/, | ||
| ) | ||
| expect(forkExampleBlock).not.toBeNull() | ||
| expect(forkExampleBlock![0]).toContain('fork: true') | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: claude-code-best/claude-code
Length of output: 1544
🏁 Script executed:
Repository: claude-code-best/claude-code
Length of output: 99
🏁 Script executed:
Repository: claude-code-best/claude-code
Length of output: 2893
🏁 Script executed:
Repository: claude-code-best/claude-code
Length of output: 3289
🏁 Script executed:
Repository: claude-code-best/claude-code
Length of output: 1801
Add
fork: trueto the fork command's AgentTool invocation.The routing logic in AgentTool.tsx changed from implicit (omit
subagent_typeto trigger fork) to explicit (fork: trueparameter). The/forkcommand insrc/commands/fork/fork.tsx(lines 42–48) has not been updated and still relies on the old implicit behavior. Withoutfork: true, the fork command will spawn a general-purpose agent instead of a fork, silently producing incorrect behavior.Required fix
const input = { prompt: directive, + fork: true, run_in_background: true, description: `Fork: ${directive.slice(0, 30)}${directive.length > 30 ? '...' : ''}`, };🤖 Prompt for AI Agents