Skip to content

fix(dom): bubble drop target state to droppable ancestors (closes #1812)#2064

Open
timagixe wants to merge 1 commit into
clauderic:mainfrom
timagixe:issues/1812
Open

fix(dom): bubble drop target state to droppable ancestors (closes #1812)#2064
timagixe wants to merge 1 commit into
clauderic:mainfrom
timagixe:issues/1812

Conversation

@timagixe

Copy link
Copy Markdown
Contributor

Summary

Fixes isDropTarget so DOM droppable ancestors become active when a nested droppable is the current drop target.

Closes #1812

Details

  • Bubbles drop target state through DOM ancestry instead of collision candidates
  • Keeps disabled and non-accepting droppables inactive
  • Adds regression coverage for nested targets and unrelated colliding siblings

Verification

  • bun test packages/dom/tests
  • bun test packages/abstract/tests
  • bun run build

@changeset-bot

changeset-bot Bot commented May 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 589e867

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@dnd-kit/dom Patch
@dnd-kit/abstract Patch
@dnd-kit/collision Patch
@dnd-kit/geometry Patch
@dnd-kit/helpers Patch
@dnd-kit/react Patch
@dnd-kit/state Patch
@dnd-kit/vue Patch
@dnd-kit/solid Patch
@dnd-kit/svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented May 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

@dnd-kit/abstract

npm i https://pkg.pr.new/@dnd-kit/abstract@2064

@dnd-kit/collision

npm i https://pkg.pr.new/@dnd-kit/collision@2064

@dnd-kit/dom

npm i https://pkg.pr.new/@dnd-kit/dom@2064

@dnd-kit/geometry

npm i https://pkg.pr.new/@dnd-kit/geometry@2064

@dnd-kit/helpers

npm i https://pkg.pr.new/@dnd-kit/helpers@2064

@dnd-kit/react

npm i https://pkg.pr.new/@dnd-kit/react@2064

@dnd-kit/solid

npm i https://pkg.pr.new/@dnd-kit/solid@2064

@dnd-kit/state

npm i https://pkg.pr.new/@dnd-kit/state@2064

@dnd-kit/svelte

npm i https://pkg.pr.new/@dnd-kit/svelte@2064

@dnd-kit/vue

npm i https://pkg.pr.new/@dnd-kit/vue@2064

commit: 589e867

@clauderic clauderic added bug Something isn't working dom DOM package labels May 28, 2026
clauderic

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dom DOM package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[experimental] isDropTarget is not bubbling to Droppable when it's true for Sortables above

2 participants