Skip to content

Support React v. 18#844

Open
patrykboch wants to merge 2 commits intoclauderic:masterfrom
patrykboch:bump-react-18-in-peer-deps
Open

Support React v. 18#844
patrykboch wants to merge 2 commits intoclauderic:masterfrom
patrykboch:bump-react-18-in-peer-deps

Conversation

@patrykboch
Copy link
Copy Markdown

@patrykboch patrykboch commented Jun 2, 2022

Fixes #838

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jun 2, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f28d4ac:

Sandbox Source
react-sortable-hoc-starter Configuration

@patrykboch
Copy link
Copy Markdown
Author

patrykboch commented Jun 8, 2022

@clauderic please review

@patrykboch
Types: change React.SFC and React.ComponentClass with `React.Comp…
f28d4ac 
…onentType`

* `React.SFC` type is no longer supported with React v. 18 (becomes `React.FC`)
* Since `React.ComponentClass` was specified the proper type now is `React.ComponentType` that covers both `React.FC` and `React.ComponentClass`
@patrykboch patrykboch changed the title Add react 18.1.0 to peer deps Support React v. 18 Jun 10, 2022
@chrishawn
Copy link
Copy Markdown

chrishawn commented Jun 15, 2022

yes please review

@patrykboch
Copy link
Copy Markdown
Author

patrykboch commented Jun 15, 2022 •
edited
Loading

@chrishawn I'm afraid it might never be introduced. The lib is considered deprecated and further enhancements won't be merged. Only security fixes. See @dnd/kit as an alternative.

Anyways migration to @dnd/kit is not obvious and it'd be perfect to have the support of React v18 here. The newest version of React does ensure backward compatibility.

I see that ReactDOM.findDOMnode, ReactDOM.render, etc. are in fact deprecated but it does not mean they neither work with the latest React nor the lib in question. So please, @clauderic consider this.

@alexander-schranz alexander-schranz mentioned this pull request Jul 10, 2022
Closed
@alexander-schranz
Copy link
Copy Markdown

alexander-schranz commented Jul 10, 2022

Would also like to see this merged. We can also not migrate away currently to another package. So would really like to see 18 official supported here.

@arneee
Copy link
Copy Markdown

arneee commented Jul 19, 2022

@clauderic : Please support that. We are using this package on so many pages so it will be a huge effort to migrate. Since the methods are still there (only deprecated), I really hope that this will be merged. Thanks!!!

@SergioArrighi
Copy link
Copy Markdown

SergioArrighi commented Sep 7, 2022

Hello,
thanks for your work.
Any target date for this to be merged?
Best regards

@marwin1991
Copy link
Copy Markdown

marwin1991 commented Sep 18, 2022

@clauderic Is there any migration guide to dnd-kit?

@williamstein williamstein mentioned this pull request Nov 1, 2022
Closed
2 tasks
@marco-adapttech
Copy link
Copy Markdown

marco-adapttech commented Nov 18, 2022

Hello,

Any updates for when it will be released?

Thanks everyone for the work.

@Artexoid
Copy link
Copy Markdown

Artexoid commented Mar 1, 2023 •
edited
Loading

Hi guys, merge it please.

@3y3 3y3 mentioned this pull request Nov 22, 2023
Closed
@nicklasbekkevold
Copy link
Copy Markdown

nicklasbekkevold commented Jan 29, 2026

Hello from 2026. Any updates on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@ahmetozantekin ahmetozantekin ahmetozantekin approved these changes

@rcuellartso rcuellartso rcuellartso approved these changes

@mdemian-verys mdemian-verys mdemian-verys approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Not supporting in react@18.0.0