linting

Author: javvaji-devops

cleancloud/providers/gcp/rules/ai/workbench_idle.py

@@ -55,9 +55,7 @@
 # Exact documented resource-name pattern (spec 3.1, 7):
 #   projects/{projectId}/locations/{location}/instances/{instanceId}
 # All four non-empty path segments must be present.
-_INSTANCE_NAME_RE = re.compile(
-    r"^projects/[^/]+/locations/[^/]+/instances/[^/]+$"
-)
+_INSTANCE_NAME_RE = re.compile(r"^projects/[^/]+/locations/[^/]+/instances/[^/]+$")
 
 
 def find_idle_workbench_instances(
@@ -117,10 +115,7 @@ def _list_instances(
     results: list = []
     unreachable: list = []
     discovery_failed = False
-    url = (
-        f"https://notebooks.googleapis.com/v2"
-        f"/projects/{project_id}/locations/-/instances"
-    )
+    url = f"https://notebooks.googleapis.com/v2" f"/projects/{project_id}/locations/-/instances"
     params: dict = {"pageSize": 100}
 
     while True:

tests/cleancloud/providers/azure/test_azure_app_service_idle.py

@@ -792,7 +792,7 @@ def _failing_iter(*args, **kwargs):
             # Yield nothing, then raise — simulates a pager that fails before
             # returning any results (first page network error, etc.)
             raise Exception("pager failed mid-iteration")
-            yield  # noqa: unreachable — makes this a generator
+            yield  # makes this a generator
 
         web.web_apps.list_web_jobs.side_effect = _failing_iter
         findings = find_idle_app_services(

tests/cleancloud/providers/gcp/ai/test_gcp_workbench_idle.py

@@ -80,9 +80,7 @@ def _invoke(**kwargs):
         "cleancloud.providers.gcp.rules.ai.workbench_idle.AuthorizedSession",
         return_value=_session(_ok()),
     ):
-        return find_idle_workbench_instances(
-            project_id=_PROJECT, credentials=MagicMock(), **kwargs
-        )
+        return find_idle_workbench_instances(project_id=_PROJECT, credentials=MagicMock(), **kwargs)
 
 
 def _invoke_with_session(mock_session, **kwargs):
@@ -91,9 +89,7 @@ def _invoke_with_session(mock_session, **kwargs):
         "cleancloud.providers.gcp.rules.ai.workbench_idle.AuthorizedSession",
         return_value=mock_session,
     ):
-        return find_idle_workbench_instances(
-            project_id=_PROJECT, credentials=MagicMock(), **kwargs
-        )
+        return find_idle_workbench_instances(project_id=_PROJECT, credentials=MagicMock(), **kwargs)
 
 
 # ---------------------------------------------------------------------------
@@ -110,13 +106,19 @@ def test_always_empty(self):
 
     def test_empty_when_api_returns_active_instances(self):
         """EMITTING_DISABLED: ACTIVE instances in API response still yield no findings."""
-        inst = {"name": f"projects/{_PROJECT}/locations/us-central1/instances/wb-1", "state": "ACTIVE"}
+        inst = {
+            "name": f"projects/{_PROJECT}/locations/us-central1/instances/wb-1",
+            "state": "ACTIVE",
+        }
         result = _invoke_with_session(_session(_ok({"instances": [inst]})))
         assert result == []
 
     def test_empty_when_api_returns_multiple_instances(self):
         instances = [
-            {"name": f"projects/{_PROJECT}/locations/us-central1/instances/wb-{i}", "state": "ACTIVE"}
+            {
+                "name": f"projects/{_PROJECT}/locations/us-central1/instances/wb-{i}",
+                "state": "ACTIVE",
+            }
             for i in range(5)
         ]
         result = _invoke_with_session(_session(_ok({"instances": instances})))
@@ -131,9 +133,7 @@ def test_empty_when_api_returns_multiple_instances(self):
 class TestIdleDaysValidation:
     def test_zero_raises_value_error(self):
         with pytest.raises(ValueError, match="idle_days must be >= 1"):
-            find_idle_workbench_instances(
-                project_id=_PROJECT, credentials=MagicMock(), idle_days=0
-            )
+            find_idle_workbench_instances(project_id=_PROJECT, credentials=MagicMock(), idle_days=0)
 
     def test_negative_one_raises(self):
         with pytest.raises(ValueError, match="idle_days must be >= 1"):
@@ -352,6 +352,7 @@ def test_two_pages_accumulates_instances(self):
     def test_three_pages_all_accumulated(self):
         def _inst(i):
             return {"name": f"projects/p/locations/us-central1/instances/i{i}", "state": "ACTIVE"}
+
         session = _session(
             _ok({"instances": [_inst(1)], "nextPageToken": "t1"}),
             _ok({"instances": [_inst(2)], "nextPageToken": "t2"}),