Skip to content

Commit 981aee0

Browse files
authored
Fix issues identified by end user (#138)
1 parent 0333788 commit 981aee0

5 files changed

Lines changed: 5 additions & 8 deletions

File tree

cleancloud/providers/azure/rules/ebs_snapshots_old.py renamed to cleancloud/providers/azure/rules/disk_snapshots_old.py

File renamed without changes.

cleancloud/providers/azure/scan.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
from cleancloud.providers.azure.rules.container_registry_unused import (
2323
find_unused_container_registries,
2424
)
25-
from cleancloud.providers.azure.rules.ebs_snapshots_old import find_old_snapshots
25+
from cleancloud.providers.azure.rules.disk_snapshots_old import find_old_snapshots
2626
from cleancloud.providers.azure.rules.lb_no_backends import find_lb_no_backends
2727
from cleancloud.providers.azure.rules.public_ip_unused import find_unused_public_ips
2828
from cleancloud.providers.azure.rules.sql_database_idle import find_idle_sql_databases

cleancloud/scan/command.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -843,10 +843,7 @@ def scan(
843843
click.echo()
844844
click.echo(f"Authentication failed — {e}")
845845
click.echo()
846-
if provider == "gcp":
847-
click.echo("Run `cleancloud doctor --provider gcp` to diagnose.")
848-
else:
849-
click.echo("Run `cleancloud doctor --provider azure` to diagnose.")
846+
click.echo(f"Run `cleancloud doctor --provider {provider}` to diagnose.")
850847
sys.exit(EXIT_PERMISSION_ERROR)
851848

852849
except botocore.exceptions.NoCredentialsError:

tests/cleancloud/providers/azure/test_azure_ebs_snapshots_old.py renamed to tests/cleancloud/providers/azure/test_azure_disk_snapshots_old.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from datetime import datetime, timedelta, timezone
22
from types import SimpleNamespace
33

4-
from cleancloud.providers.azure.rules.ebs_snapshots_old import find_old_snapshots
4+
from cleancloud.providers.azure.rules.disk_snapshots_old import find_old_snapshots
55

66

77
def test_find_old_snapshots(monkeypatch):
@@ -40,7 +40,7 @@ def __init__(self, credential, subscription_id):
4040
self.snapshots = MockSnapshots()
4141

4242
monkeypatch.setattr(
43-
"cleancloud.providers.azure.rules.ebs_snapshots_old.ComputeManagementClient",
43+
"cleancloud.providers.azure.rules.disk_snapshots_old.ComputeManagementClient",
4444
MockComputeClient,
4545
)
4646

tests/e2e/azure/test_azure_rules_smoke.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from cleancloud.providers.azure.rules.container_registry_unused import (
1010
find_unused_container_registries,
1111
)
12-
from cleancloud.providers.azure.rules.ebs_snapshots_old import find_old_snapshots
12+
from cleancloud.providers.azure.rules.disk_snapshots_old import find_old_snapshots
1313
from cleancloud.providers.azure.rules.lb_no_backends import find_lb_no_backends
1414
from cleancloud.providers.azure.rules.public_ip_unused import find_unused_public_ips
1515
from cleancloud.providers.azure.rules.sql_database_idle import find_idle_sql_databases

0 commit comments

Comments
 (0)