Fix stale naming and default in recompute provider wiring

Rename upgradeAzureQueueConfig/upgradeMemoryQueueConfig import aliases to
recomputeAzureQueueConfig/recomputeMemoryQueueConfig in providers/index.ts —
these configs provide both upgrade and compute queue factories, so the
upgrade-only prefix was misleading.

Change the fallback default in bin/config.ts from 'versionCheck' (deprecated
alias) to 'onDemand' so a clean deployment with no env var set uses the
current non-deprecated value.

Author: qtomlinson

bin/config.ts

@@ -179,7 +179,7 @@ export default {
       'recompute.queue'
     ),
     service: loadFactory(
-      config.get('DEFINITION_RECOMPUTE_PROVIDER') || config.get('DEFINITION_UPGRADE_PROVIDER') || 'versionCheck',
+      config.get('DEFINITION_RECOMPUTE_PROVIDER') || config.get('DEFINITION_UPGRADE_PROVIDER') || 'onDemand',
       'recompute.service'
     )
   },

providers/index.ts

@@ -13,8 +13,8 @@ import crawlerConfig from '../providers/harvest/crawlerConfig.ts'
 import crawlerQueueConfig from '../providers/harvest/crawlerQueueConfig.ts'
 import winstonConfig from '../providers/logging/winstonConfig.ts'
 import memoryQueue from '../providers/queueing/memoryQueue.ts'
-import upgradeAzureQueueConfig from '../providers/recompute/azureQueueConfig.ts'
-import upgradeMemoryQueueConfig from '../providers/recompute/memoryQueueConfig.ts'
+import recomputeAzureQueueConfig from '../providers/recompute/azureQueueConfig.ts'
+import recomputeMemoryQueueConfig from '../providers/recompute/memoryQueueConfig.ts'
 import recomputeHandler from '../providers/recompute/recomputeHandler.ts'
 import azureSearchConfig from '../providers/search/azureConfig.ts'
 import memorySearch from '../providers/search/memory.ts'
@@ -185,8 +185,8 @@ const providers: Providers = {
   },
   recompute: {
     queue: {
-      azure: upgradeAzureQueueConfig,
-      memory: upgradeMemoryQueueConfig
+      azure: recomputeAzureQueueConfig,
+      memory: recomputeMemoryQueueConfig
     },
     service: {
       onDemand: recomputeHandler.defaultFactory,

providers/recompute/recomputeHandler.ts

@@ -106,7 +106,7 @@ function getPolicyName(policy: any): string {
 }
 
 /**
- * Compatibility alias for DEFINITION_UPGRADE_PROVIDER=versionCheck.
+ * Factory for DEFINITION_RECOMPUTE_PROVIDER=onDemand (alias: versionCheck).
  * Only `logger` is used from options; any other properties (e.g. `queue`) are intentionally ignored.
  */
 function defaultFactory({ logger }: Pick<DefinitionVersionCheckerOptions, 'logger'> = {}): RecomputeHandler {
@@ -118,7 +118,7 @@ function defaultFactory({ logger }: Pick<DefinitionVersionCheckerOptions, 'logge
 }
 
 /**
- * Compatibility alias for DEFINITION_UPGRADE_PROVIDER=upgradeQueue.
+ * Factory for DEFINITION_RECOMPUTE_PROVIDER=delayed (alias: upgradeQueue).
  */
 function delayedFactory(options: DelayedFactoryOptions = {}): RecomputeHandler {
   const shared = {