Skip to content

Fix gamma function crash for large input #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nezznee wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix gamma function crash for large input #622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea67090
Fix https://github.com/clementwzk/OpenCalc/issues/600
May 16, 2026
0e6da62
Use Double#isInfinite instead of !Double#isFinite as isFinite also ch…
May 18, 2026
3394303
Nevermind it can be NaN so !isFinite is needed..:
May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/src/main/java/com/darkempire78/opencalculator/calculator/Calculator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ class Calculator(
val firstPart = sqrtTwoPi * t.pow(z + 0.5) * exp(-t)
val result = firstPart * a

if (!result.isFinite()) {
is_infinity = true
return BigDecimal.ZERO
}
return BigDecimal(result, MathContext.DECIMAL64)
}

Expand Down
5 changes: 4 additions & 1 deletion app/src/test/java/com/darkempire78/opencalculator/ExpressionUnitTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class ExpressionUnitTest {
Samsung Calculator has a result of 22.76976 here and Google Calculator yields 16.732.
OpenCalc yields 18.75176. 4Investigating the correct answer.
We typically would not do something so ambiguous. Are we adding percentages or adding a
a percentage of the previous number? An answer of 7.21 is also possible. How far down
percentage of the previous number? An answer of 7.21 is also possible. How far down
this rabbit hole do we want to go? Everyday calculations should be correct now.
*/
result = calculate("164%+(265-20%)%+345%", isDegreeModeActivated = false).toDouble()
Expand Down Expand Up @@ -190,6 +190,9 @@ class ExpressionUnitTest {

result = calculate("(3!)!/(3!)!", false).toDouble()
assertEquals(1.0, result, 0.0)

result = calculate("(21.3*12.5)!",false).toDouble()
assertEquals(0.0, result, 0.0)
}

@Test
Expand Down