test(plugin-completions): update test

Author: so1ve

packages/plugin-completions/test/commands.test.ts

@@ -35,31 +35,21 @@ describe("plugin-completions/commands", () => {
 		});
 
 		it("should throw error if shell is missing", async () => {
-			const cli = TestBaseCli().use(completionsPlugin());
-			const errorFn = vi.fn();
-			cli.errorHandler(errorFn);
-
-			await cli.parse(["completions", "install"]);
-
-			await new Promise((resolve) => setTimeout(resolve, 10));
-
-			expect(errorFn).toHaveBeenCalled();
-			expect(errorFn.mock.calls[0][0].message).toContain(
-				"Please specify the shell type",
-			);
+			await expect(async () => {
+				await TestBaseCli()
+					.use(completionsPlugin())
+					.parse(["completions", "install"]);
+			}).rejects.toThrow("Please specify the shell type");
 		});
 
 		it("should throw error if shell is unsupported", async () => {
-			const cli = TestBaseCli().use(completionsPlugin());
-			const errorFn = vi.fn();
-			cli.errorHandler(errorFn);
-
-			await cli.parse(["completions", "install", "--shell", "invalid"]);
-
-			await new Promise((resolve) => setTimeout(resolve, 10));
-
-			expect(errorFn).toHaveBeenCalled();
-			expect(errorFn.mock.calls[0][0].message).toContain("Unsupported shell");
+			await expect(async () => {
+				await TestBaseCli()
+					.use(completionsPlugin())
+					.parse(["completions", "install", "--shell", "invalid"]);
+			}).rejects.toThrowErrorMatchingInlineSnapshot(
+				"[Error: Invalid value: invalid. Must be one of: bash, zsh, fish]",
+			);
 		});
 	});
 
@@ -93,31 +83,19 @@ describe("plugin-completions/commands", () => {
 		});
 
 		it("should throw error if shell is missing", async () => {
-			const cli = TestBaseCli().use(completionsPlugin());
-			const errorFn = vi.fn();
-			cli.errorHandler(errorFn);
-
-			await cli.parse(["completions"]);
-
-			await new Promise((resolve) => setTimeout(resolve, 10));
-
-			expect(errorFn).toHaveBeenCalled();
-			expect(errorFn.mock.calls[0][0].message).toContain(
-				"Please specify the shell type",
-			);
+			await expect(async () => {
+				await TestBaseCli().use(completionsPlugin()).parse(["completions"]);
+			}).rejects.toThrow("Please specify the shell type");
 		});
 
 		it("should throw error if shell is unsupported", async () => {
-			const cli = TestBaseCli().use(completionsPlugin());
-			const errorFn = vi.fn();
-			cli.errorHandler(errorFn);
-
-			await cli.parse(["completions", "--shell", "invalid"]);
-
-			await new Promise((resolve) => setTimeout(resolve, 10));
-
-			expect(errorFn).toHaveBeenCalled();
-			expect(errorFn.mock.calls[0][0].message).toContain("Unsupported shell");
+			await expect(async () => {
+				await TestBaseCli()
+					.use(completionsPlugin())
+					.parse(["completions", "--shell", "invalid"]);
+			}).rejects.toThrowErrorMatchingInlineSnapshot(
+				"[Error: Invalid value: invalid. Must be one of: bash, zsh, fish]",
+			);
 		});
 	});
 

packages/plugin-completions/test/plugin-completions.test.ts

@@ -32,7 +32,6 @@ describe("plugin-completions", () => {
 		expect(completionsCmd).toBeDefined();
 		expect(completionsCmd?.flags).toBeDefined();
 		expect(completionsCmd?.flags?.shell).toBeDefined();
-		expect(completionsCmd?.parameters).toContain("[shell]");
 	});
 
 	it("should have completion-server command hidden from help", () => {
@@ -65,7 +64,6 @@ describe("plugin-completions", () => {
 		expect(installCmd).toBeDefined();
 		expect(installCmd?.flags).toBeDefined();
 		expect(installCmd?.flags?.shell).toBeDefined();
-		expect(installCmd?.parameters).toContain("[shell]");
 
 		const uninstallCmd = cli._commands.get("completions uninstall");