Skip to content

Add AGENTS.md and document docs conventions in CONTRIBUTING and STYLEGUIDE#3385

Merged
manovotny merged 5 commits into
mainfrom
manovotny/flourish-supply
May 26, 2026
Merged

Add AGENTS.md and document docs conventions in CONTRIBUTING and STYLEGUIDE#3385
manovotny merged 5 commits into
mainfrom
manovotny/flourish-supply

Conversation

@manovotny

@manovotny manovotny commented May 20, 2026

Copy link
Copy Markdown
Collaborator

🔎 Previews:

  • No rendered docs pages changed. This PR only touches AGENTS.md, CLAUDE.md, contributing/CONTRIBUTING.md, and styleguides/STYLEGUIDE.md — none of which are published under /docs.

What does this solve? What changed?

Some conventions a contributor (or AI agent) needs aren't written down anywhere, so nothing — human or agent — could check against them. #3176 ("feat: Agent Tasks") shipped a production build failure plus several convention gaps that follow-up #3383 had to clean up. This PR records those conventions and adds agent guidance.

  • Add AGENTS.md (tool-neutral agent entry point) and CLAUDE.md (a one-line @AGENTS.md import). AGENTS.md leads with what surprises agents: never read secrets; an invalid sdk: frontmatter value is a hard build failure; run pnpm run build:tsx + pnpm run lint before declaring work done; a repo map; and pointers to the human docs. It carries terse operational rules and routes to CONTRIBUTING/STYLEGUIDE for depth, so no rule is duplicated.
  • CONTRIBUTING.md
    • Rewrote "Validating your changes": removed the dead check-links.mjs reference (the file no longer exists), added pnpm run build:tsx, explained the hard-fail vs warning split (invalid sdk/missing title fail the build; missing description, a doc not in manifest.json, and broken internal links only warn), and added a stale-PR rebase hazard.
    • Corrected the frontmatter guidance so title reads as required and description as recommended but only a warning when missing.
    • Added "Authoring SDK code examples" (match the canonical create-user.mdx/delete-user.mdx partials per SDK; the build never executes code blocks) and "Documenting a new feature or reference" (beta callout partial + (Beta) tag, hand-authored type pages, required-vs-optional frontmatter precision).
    • Fixed pre-existing broken relative links (./docs/…, ./styleguides/…../…); the file lives in contributing/, so the old paths resolved to the wrong place.
  • STYLEGUIDE.md: added "Capitalize Clerk feature proper nouns" (e.g. "Agent Tasks") as an extension of the existing Next.js proper-noun rule.

Verified locally: pnpm run build:tsx (exit 0) and pnpm run lint (exit 0).

Deadline

  • No rush

Other resources

…GUIDE

Add agent guidance and write down conventions that previously weren't
documented anywhere, so reviewers (human or agent) can check against them.

- Add AGENTS.md (tool-neutral agent entry point) and CLAUDE.md (one-line
  @AGENTS.md import) covering secrets, the invalid-sdk hard failure, the
  build/lint verify step, a repo map, and pointers to the human docs
- CONTRIBUTING: rewrite "Validating your changes" (drop the dead
  check-links.mjs reference, add build:tsx, the hard-fail vs warning
  split, and the stale-PR hazard); correct the title/description
  required-vs-optional severity; add "Authoring SDK code examples" and
  "Documenting a new feature or reference" subsections
- STYLEGUIDE: capitalize Clerk feature proper nouns (e.g. "Agent Tasks")
- Fix pre-existing broken ./docs and ./styleguides links in CONTRIBUTING
  (the file lives in contributing/, so they needed ../ paths)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented May 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-docs Ready Ready Preview May 22, 2026 6:35pm

Request Review

@manovotny manovotny marked this pull request as ready for review May 20, 2026 15:35
@manovotny manovotny requested a review from a team as a code owner May 20, 2026 15:35
Comment thread contributing/CONTRIBUTING.md Outdated
Comment thread contributing/CONTRIBUTING.md Outdated
Comment thread styleguides/STYLEGUIDE.md Outdated
Comment thread AGENTS.md Outdated
@alexisintech

alexisintech commented May 20, 2026

Copy link
Copy Markdown
Contributor

I think these are good additions and starting points - thanks for conjuring these up! I left a few comments :)

Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
…ript

- Remove the redundant frontmatter-precision bullet and the duplicative
  closing beta caveat from the "Documenting a new feature or reference"
  section in CONTRIBUTING (both restated guidance already stated elsewhere)
- Link the clerk/javascript repo reference in AGENTS.md

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
clerk-docs documents APIs and SDKs it doesn't own, so content can be
syntactically valid yet factually wrong — and build:tsx/lint won't catch it.

- AGENTS.md: add a "Verifying technical claims" section naming the
  sources of truth (clerk/clerk_go for API behavior/endpoints/versions/
  OpenAPI, clerk/javascript for SDK signatures, clerk/clerk for how the
  docs/reference render); verify against source, not memory, and don't
  defer checkable facts to the PR author
- CONTRIBUTING.md: one-line pointer to that section from "Validating your
  changes" (depth stays in AGENTS.md, no duplication)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The File metadata intro said "a few required frontmatter fields," which
contradicted the clarification just below it that only `title` is required
and `description` only warns. Drop "a few required."

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@manovotny manovotny merged commit af077af into main May 26, 2026
8 checks passed
@manovotny manovotny deleted the manovotny/flourish-supply branch May 26, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants