refactor(plapi): allow null active_domain and guard in deploy wizard

Author: wyattjoh

packages/cli-core/src/commands/deploy/api.test.ts

@@ -63,7 +63,7 @@ describe("deploy api adapter", () => {
     });
 
     expect(production.instance_id).toBe("MOCKED_NOT_REAL_FIXME");
-    expect(production.active_domain.name).toBe("example.com");
+    expect(production.active_domain?.name).toBe("example.com");
     expect(production.cname_targets).toHaveLength(3);
     expect(mockPlapiCreateProductionInstance).not.toHaveBeenCalled();
     expect(mockPlapiValidateCloning).not.toHaveBeenCalled();

packages/cli-core/src/commands/deploy/index.test.ts

@@ -1493,6 +1493,43 @@ describe("deploy", () => {
       expect(err).toContain("Configure them from the Clerk Dashboard before going live");
     });
 
+    test("throws a CliError when createProductionInstance returns no active_domain", async () => {
+      _modeOverride = "human";
+      await linkedProject({
+        appId: "app_test",
+        appName: "Test App",
+        instances: { development: "ins_dev" },
+      });
+      mockFetchApplication.mockResolvedValue({
+        application_id: "app_test",
+        name: "Test App",
+        instances: [
+          { instance_id: "ins_dev", environment_type: "development", publishable_key: "pk_test" },
+        ],
+      });
+      mockFetchInstanceConfig.mockResolvedValue({});
+      mockConfirm.mockResolvedValue(true);
+      mockInput.mockResolvedValue("https://example.com");
+
+      mockCreateProductionInstance.mockResolvedValue({
+        instance_id: "ins_prod",
+        environment_type: "production",
+        active_domain: null,
+        secret_key: "sk_live_x",
+        publishable_key: "pk_live_x",
+        cname_targets: [],
+      });
+
+      let thrown: unknown;
+      try {
+        await runDeploy({});
+      } catch (e) {
+        thrown = e;
+      }
+      expect(thrown).toBeInstanceOf(CliError);
+      expect((thrown as CliError).message).toContain("did not return a domain");
+    });
+
     test("recovers from production_instance_exists by resuming reconcileExistingDeploy", async () => {
       _modeOverride = "human";
       await linkedProject({

packages/cli-core/src/commands/deploy/index.ts

@@ -278,6 +278,14 @@ async function startNewDeploy(ctx: DeployContext): Promise<void> {
     throw error;
   }
   await persistProductionInstance(ctx, production.instance_id);
+
+  if (!production.active_domain) {
+    throw new CliError(
+      "Production instance was created but Clerk did not return a domain. " +
+        "Run `clerk deploy` again to retry domain provisioning.",
+    );
+  }
+
   log.blank();
 
   const productionDomain = production.active_domain.name;

packages/cli-core/src/lib/plapi.ts

@@ -174,7 +174,8 @@ export type ListApplicationDomainsResponse = {
 export type ProductionInstanceResponse = {
   instance_id: string;
   environment_type: "production";
-  active_domain: DomainSummary;
+  /** Server contract permits null; CLI currently throws if the server omits it. */
+  active_domain: DomainSummary | null;
   secret_key?: string;
   publishable_key: string;
   cname_targets: CnameTarget[];