feat(deploy/mock): inject production_instance_exists and unsupported plan features

Author: wyattjoh

packages/cli-core/src/commands/deploy/mock.test.ts

@@ -5,6 +5,9 @@ import {
   resolveTestDeployFlags,
   withMockProductionInstance,
   withTestFailureAfterApiCall,
+  mockDeployApi,
+  configureMockDeployApi,
+  _resetDeployStatusMock,
 } from "./mock.ts";
 
 describe("resolveTestDeployFlags", () => {
@@ -14,7 +17,9 @@ describe("resolveTestDeployFlags", () => {
       testFailProductionInstanceCheck: false,
       testFailDomainLookup: false,
       testFailValidateCloning: false,
+      testFailValidateCloningUnsupportedFeatures: undefined,
       testFailCreateProductionInstance: false,
+      testFailCreateProductionInstanceExists: false,
       testFailDnsVerification: false,
       testFailOAuthSave: false,
     });
@@ -31,7 +36,9 @@ describe("resolveTestDeployFlags", () => {
       testFailProductionInstanceCheck: false,
       testFailDomainLookup: false,
       testFailValidateCloning: false,
+      testFailValidateCloningUnsupportedFeatures: undefined,
       testFailCreateProductionInstance: false,
+      testFailCreateProductionInstanceExists: false,
       testFailDnsVerification: true,
       testFailOAuthSave: false,
     });
@@ -156,8 +163,41 @@ describe("withMockProductionInstance", () => {
 
     const result = withMockProductionInstance(stagingOnly);
     expect(result.instances).toHaveLength(2);
-    expect(
-      result.instances.some((instance) => instance.environment_type === "production"),
-    ).toBe(true);
+    expect(result.instances.some((instance) => instance.environment_type === "production")).toBe(
+      true,
+    );
+  });
+});
+
+describe("mockDeployApi failure injection — specific error codes", () => {
+  test("failCreateProductionInstanceExists throws PlapiError with code production_instance_exists", async () => {
+    _resetDeployStatusMock();
+    configureMockDeployApi({ failCreateProductionInstanceExists: true });
+    let thrown: unknown;
+    try {
+      await mockDeployApi.createProductionInstance("app_x", { home_url: "https://example.com" });
+    } catch (e) {
+      thrown = e;
+    }
+    expect(thrown).toBeInstanceOf(PlapiError);
+    const err = thrown as PlapiError;
+    expect(err.status).toBe(400);
+    expect(err.code).toBe("production_instance_exists");
+  });
+
+  test("failValidateCloningUnsupportedFeatures throws 402 with meta.unsupported_features", async () => {
+    _resetDeployStatusMock();
+    configureMockDeployApi({ failValidateCloningUnsupportedFeatures: ["saml", "mfa"] });
+    let thrown: unknown;
+    try {
+      await mockDeployApi.validateCloning("app_x", { clone_instance_id: "ins_dev" });
+    } catch (e) {
+      thrown = e;
+    }
+    expect(thrown).toBeInstanceOf(PlapiError);
+    const err = thrown as PlapiError;
+    expect(err.status).toBe(402);
+    expect(err.code).toBe("unsupported_subscription_plan_features");
+    expect(err.meta).toEqual({ unsupported_features: ["saml", "mfa"] });
   });
 });

packages/cli-core/src/commands/deploy/mock.ts

@@ -21,7 +21,11 @@ const MOCK_INCOMPLETE_POLLS = 2;
 
 export type DeployApiMockOptions = {
   failValidateCloning?: boolean;
+  /** Simulates HTTP 402 unsupported_subscription_plan_features with this feature list. */
+  failValidateCloningUnsupportedFeatures?: string[];
   failCreateProductionInstance?: boolean;
+  /** Simulates HTTP 400 production_instance_exists. */
+  failCreateProductionInstanceExists?: boolean;
   failDnsVerification?: boolean;
   failOAuthSave?: boolean;
 };
@@ -31,7 +35,9 @@ export type DeployTestFlags = {
   testFailProductionInstanceCheck?: boolean;
   testFailDomainLookup?: boolean;
   testFailValidateCloning?: boolean;
+  testFailValidateCloningUnsupportedFeatures?: string[];
   testFailCreateProductionInstance?: boolean;
+  testFailCreateProductionInstanceExists?: boolean;
   testFailDnsVerification?: boolean;
   testFailOAuthSave?: boolean;
 };
@@ -47,7 +53,9 @@ export function resolveTestDeployFlags(options: {
   testFailProductionInstanceCheck?: boolean;
   testFailDomainLookup?: boolean;
   testFailValidateCloning?: boolean;
+  testFailValidateCloningUnsupportedFeatures?: string[];
   testFailCreateProductionInstance?: boolean;
+  testFailCreateProductionInstanceExists?: boolean;
   testFailDnsVerification?: boolean;
   testFailOAuthSave?: boolean;
 }): DeployTestFlags {
@@ -56,7 +64,9 @@ export function resolveTestDeployFlags(options: {
     testFailProductionInstanceCheck: options.testFailProductionInstanceCheck === true,
     testFailDomainLookup: options.testFailDomainLookup === true,
     testFailValidateCloning: options.testFailValidateCloning === true,
+    testFailValidateCloningUnsupportedFeatures: options.testFailValidateCloningUnsupportedFeatures,
     testFailCreateProductionInstance: options.testFailCreateProductionInstance === true,
+    testFailCreateProductionInstanceExists: options.testFailCreateProductionInstanceExists === true,
     testFailDnsVerification: options.testFailDnsVerification === true,
     testFailOAuthSave: options.testFailOAuthSave === true,
   };
@@ -105,12 +115,31 @@ export function _resetDeployStatusMock(): void {
   configureMockDeployApi();
 }
 
+function simulatedSpecificFailure(
+  status: number,
+  code: string,
+  message: string,
+  meta?: Record<string, unknown>,
+): PlapiError {
+  const body = JSON.stringify({
+    errors: [{ code, message, ...(meta ? { meta } : {}) }],
+  });
+  return PlapiError.fromBody(status, body, "clerk deploy mock");
+}
+
 export const mockDeployApi: DeployApi = {
   async createProductionInstance(_applicationId, params) {
     await simulateServerLatency();
     if (mockOptions.failCreateProductionInstance) {
       throw simulatedDeployApiFailure("production instance creation");
     }
+    if (mockOptions.failCreateProductionInstanceExists) {
+      throw simulatedSpecificFailure(
+        400,
+        "production_instance_exists",
+        "You can only have one production instance.",
+      );
+    }
     return {
       instance_id: MOCK_PRODUCTION_INSTANCE_ID,
       environment_type: "production",
@@ -129,6 +158,14 @@ export const mockDeployApi: DeployApi = {
     if (mockOptions.failValidateCloning) {
       throw simulatedDeployApiFailure("cloning validation");
     }
+    if (mockOptions.failValidateCloningUnsupportedFeatures) {
+      throw simulatedSpecificFailure(
+        402,
+        "unsupported_subscription_plan_features",
+        "Unsupported plan features",
+        { unsupported_features: mockOptions.failValidateCloningUnsupportedFeatures },
+      );
+    }
   },
 
   async getDeployStatus(applicationId, envOrInsId) {