Skip to content

Commit 3ad74f5

Browse files
build(deps-dev): bump playwright from 1.59.1 to 1.60.0 (#296)
* build(deps-dev): bump playwright from 1.59.1 to 1.60.0 Bumps [playwright](https://github.com/microsoft/playwright) from 1.59.1 to 1.60.0. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.59.1...v1.60.0) --- updated-dependencies: - dependency-name: playwright dependency-version: 1.60.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix(deps): update Playwright patch for 1.60.0 Retarget the Bun response URL workaround patch to Playwright 1.60's bundled core file so the patch check matches the upgraded dependency. * chore: bump version of playwright container for e2e --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wyatt Johnson <accounts+github@wyattjoh.ca>
1 parent 7117fd5 commit 3ad74f5

5 files changed

Lines changed: 37 additions & 38 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ jobs:
9898
(github.event_name != 'pull_request' && inputs.run-e2e)
9999
runs-on: blacksmith-8vcpu-ubuntu-2404
100100
container:
101-
image: mcr.microsoft.com/playwright:v1.59.1-noble
101+
image: mcr.microsoft.com/playwright:v1.60.0-noble
102102
timeout-minutes: 30
103103
steps:
104104
- name: Install unzip (required by setup-bun)

bun.lock

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"nano-staged": "^1.0.2",
3838
"oxfmt": "^0.47.0",
3939
"oxlint": "^1.62.0",
40-
"playwright": "^1.59.1",
40+
"playwright": "^1.60.0",
4141
"typescript": "^6"
4242
},
4343
"nano-staged": {
@@ -51,6 +51,6 @@
5151
"bun": ">=1.3.10"
5252
},
5353
"patchedDependencies": {
54-
"playwright-core@1.59.1": "patches/playwright-core@1.59.1.patch"
54+
"playwright-core@1.60.0": "patches/playwright-core@1.60.0.patch"
5555
}
5656
}

patches/playwright-core@1.59.1.patch

Lines changed: 0 additions & 31 deletions
This file was deleted.
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
# Workaround for a Bun/Node divergence: Bun populates IncomingMessage.url on
2+
# client-side responses (with the request path or redirect target), whereas
3+
# Node leaves it as "". Playwright's `response.url || url.toString()` fallback
4+
# therefore picks up a relative path under Bun and crashes in `new URL(...)`
5+
# inside `_parseSetCookieHeader`. Tracked upstream at:
6+
# https://github.com/oven-sh/bun/issues/6892
7+
# Once Bun stops leaking a non-empty `url` onto client IncomingMessages, this
8+
# patch can be removed.
9+
diff --git a/lib/coreBundle.js b/lib/coreBundle.js
10+
--- a/lib/coreBundle.js
11+
+++ b/lib/coreBundle.js
12+
@@ -25987,7 +25987,8 @@
13+
progress2.log(`\u2190 ${response2.statusCode} ${response2.statusMessage}`);
14+
for (const [name, value2] of Object.entries(response2.headers))
15+
progress2.log(` ${name}: ${value2}`);
16+
- const cookies = this._parseSetCookieHeader(response2.url || url2.toString(), response2.headers["set-cookie"]);
17+
+ const resolvedResponseUrl = response2.url && response2.url.startsWith("http") ? response2.url : url2.toString();
18+
+ const cookies = this._parseSetCookieHeader(resolvedResponseUrl, response2.headers["set-cookie"]);
19+
if (cookies.length) {
20+
try {
21+
await this.addCookies(cookies);
22+
@@ -26065,7 +26066,7 @@
23+
const body2 = Buffer.concat(chunks);
24+
notifyRequestFinished(body2);
25+
fulfill({
26+
- url: response2.url || url2.toString(),
27+
+ url: response2.url && response2.url.startsWith("http") ? response2.url : url2.toString(),
28+
status: response2.statusCode || 0,
29+
statusText: response2.statusMessage || "",
30+
headers: toHeadersArray(response2.rawHeaders),

0 commit comments

Comments
 (0)