fix(deploy): remove gutter tone plumbing

Author: wyattjoh

packages/cli-core/src/commands/deploy/index.test.ts

@@ -579,7 +579,6 @@ describe("deploy", () => {
         .map((call: unknown[]) => String(call[0]))
         .join("");
       expect(terminalOutput).toContain("Cancelled");
-      expect(terminalOutput).toContain("\x1b[31m└");
       expect(terminalOutput).not.toContain("Done");
     });
 
@@ -598,7 +597,6 @@ describe("deploy", () => {
         .map((call: unknown[]) => String(call[0]))
         .join("");
       expect(terminalOutput).toContain("Cancelled");
-      expect(terminalOutput).toContain("\x1b[31m└");
       expect(terminalOutput).not.toContain("Done");
     });
 
@@ -696,7 +694,6 @@ describe("deploy", () => {
         .map((call: unknown[]) => String(call[0]))
         .join("");
       expect(terminalOutput).toContain("Paused");
-      expect(terminalOutput).toContain("\x1b[33m└");
       expect(terminalOutput).not.toContain("Done");
     });
 
@@ -880,7 +877,7 @@ describe("deploy", () => {
       expect(mockFetchInstanceConfig).not.toHaveBeenCalled();
     });
 
-    test("--test-fail-production-instance-check prints one Failed status in interactive output", async () => {
+    test("--test-fail-production-instance-check prints Failed in interactive output", async () => {
       await linkedProject();
       mockIsAgent.mockReturnValue(false);
       stderrSpy = spyOn(process.stderr, "write").mockImplementation(() => true);
@@ -909,7 +906,7 @@ describe("deploy", () => {
       const terminalOutput = stripAnsi(
         stderrSpy.mock.calls.map((call: unknown[]) => String(call[0])).join(""),
       );
-      expect(terminalOutput.match(/\bFailed\b/g) ?? []).toHaveLength(1);
+      expect(terminalOutput).toContain("Failed");
     });
 
     test("--test-fail-domain-lookup simulates production domain lookup failure", async () => {
@@ -1121,7 +1118,6 @@ describe("deploy", () => {
         .map((call: unknown[]) => String(call[0]))
         .join("");
       expect(terminalOutput).toContain("Paused");
-      expect(terminalOutput).toContain("\x1b[33m└");
       expect(terminalOutput).not.toContain("Done");
     });
 

packages/cli-core/src/commands/deploy/index.ts

@@ -1,6 +1,6 @@
 import { isAgent } from "../../mode.ts";
 import { NEXT_STEPS } from "../../lib/next-steps.ts";
-import { isInsideGutter, log, setPrefixTone, type PrefixTone } from "../../lib/log.ts";
+import { isInsideGutter, log } from "../../lib/log.ts";
 import { sleep } from "../../lib/sleep.ts";
 import { bar, intro, outro, withSpinner } from "../../lib/spinner.ts";
 import {
@@ -165,30 +165,29 @@ export async function deploy(options: DeployOptions = {}) {
     setLogLevel("debug");
   }
 
-  intro("clerk deploy", { tone: "active" });
+  intro("clerk deploy");
   try {
     const ctx = await resolveDeployContext(options);
     await runDeploy(ctx);
   } catch (error) {
     if (error instanceof DeployPausedError && isInsideGutter()) {
-      closeDeployGutter("error", "Paused");
+      closeDeployGutter("Paused");
     }
     if (isPromptExitError(error) && isInsideGutter()) {
-      closeDeployGutter("cancel", "Cancelled");
+      closeDeployGutter("Cancelled");
       throw new UserAbortError();
     }
     throw error;
   } finally {
     // Successful and paused paths call outro themselves. This balances the
     // intro gutter if an unexpected error escapes.
     if (isInsideGutter()) {
-      closeDeployGutter("error", "Failed");
+      closeDeployGutter("Failed");
     }
   }
 }
 
-function closeDeployGutter(tone: PrefixTone, messageOrSteps: string | readonly string[]): void {
-  setPrefixTone(tone);
+function closeDeployGutter(messageOrSteps: string | readonly string[]): void {
   outro(messageOrSteps);
 }
 
@@ -318,7 +317,7 @@ async function runDeploy(ctx: DeployContext): Promise<void> {
       "No Clerk project linked to this directory. Run `clerk link`, then rerun `clerk deploy`.",
     );
     log.blank();
-    closeDeployGutter("error", "Link required");
+    closeDeployGutter("Link required");
     return;
   }
 
@@ -357,7 +356,7 @@ async function startNewDeploy(ctx: DeployContext): Promise<void> {
   const proceed = await confirmProceed();
   if (!proceed) {
     log.info("No changes were made.");
-    closeDeployGutter("cancel", "Cancelled");
+    closeDeployGutter("Cancelled");
     return;
   }
 
@@ -415,7 +414,7 @@ async function reconcileExistingDeploy(ctx: DeployContext): Promise<void> {
     log.info("A production instance exists, but Clerk did not return a production domain yet.");
     log.info("Run `clerk deploy` again after the domain is available from the API.");
     log.blank();
-    closeDeployGutter("neutral", "No deploy actions available");
+    closeDeployGutter("No deploy actions available");
     return;
   }
 
@@ -708,7 +707,7 @@ async function confirmProductionInstanceCreation(
   log.blank();
   log.info("No production instance was created.");
   log.blank();
-  closeDeployGutter("cancel", "Cancelled");
+  closeDeployGutter("Cancelled");
   return false;
 }
 
@@ -736,7 +735,7 @@ async function runDnsSetup(
       log.blank();
       log.info(pausedOperationNotice());
       log.blank();
-      closeDeployGutter("error", "Paused");
+      closeDeployGutter("Paused");
       return false;
     }
     return await runDnsVerification(ctx, { ...state, cnameTargets });
@@ -857,7 +856,7 @@ async function runOAuthSetup(
         log.blank();
         log.info(pausedOperationNotice());
         log.blank();
-        closeDeployGutter("error", "Paused");
+        closeDeployGutter("Paused");
         return [...completed];
       }
     } catch (error) {
@@ -950,7 +949,7 @@ async function finishDeploy(
   log.blank();
   printNextSteps();
   log.blank();
-  closeDeployGutter("success", NEXT_STEPS.DEPLOY);
+  closeDeployGutter(NEXT_STEPS.DEPLOY);
 }
 
 function printNextSteps(): void {

packages/cli-core/src/lib/log.test.ts

@@ -7,7 +7,6 @@ import {
   getLogLevel,
   pushPrefix,
   popPrefix,
-  setPrefixTone,
   type LogLevel,
 } from "./log.ts";
 
@@ -256,25 +255,6 @@ describe("blank", () => {
     expect(cap.stderr.length).toBe(1);
     expect(cap.stderr[0]).toContain("│");
   });
-
-  test("colors pipe prefix from the active gutter tone", () => {
-    const cap = createCapture();
-
-    withCapturedLogs(cap, () => {
-      pushPrefix("active");
-      log.info("working");
-      setPrefixTone("error");
-      log.info("needs attention");
-      setPrefixTone("cancel");
-      log.info("cancelled");
-      popPrefix();
-    });
-
-    expect(cap.stderr).toHaveLength(3);
-    expect(cap.stderr[0]).toContain("\x1b[36m│");
-    expect(cap.stderr[1]).toContain("\x1b[33m│");
-    expect(cap.stderr[2]).toContain("\x1b[31m│");
-  });
 });
 
 describe("raw", () => {

packages/cli-core/src/lib/log.ts

@@ -1,5 +1,5 @@
 import { AsyncLocalStorage } from "node:async_hooks";
-import { cyan, dim, green, red, yellow } from "./color.ts";
+import { dim, green, red, yellow } from "./color.ts";
 
 // ── Log level ────────────────────────────────────────────────────────────
 
@@ -30,50 +30,24 @@ function isLevelEnabled(level: LogLevel): boolean {
 // ── Pipe prefix state (for intro/outro flow) ──────────────────────────────
 
 const S_BAR = "│";
-export type PrefixTone = "neutral" | "active" | "error" | "cancel" | "success";
+let prefixDepth = 0;
 
-const prefixTones: PrefixTone[] = [];
-
-export function pushPrefix(tone: PrefixTone = "neutral") {
-  prefixTones.push(tone);
+export function pushPrefix() {
+  prefixDepth++;
 }
 
 export function popPrefix() {
-  prefixTones.pop();
-}
-
-export function setPrefixTone(tone: PrefixTone) {
-  if (prefixTones.length === 0) return;
-  prefixTones[prefixTones.length - 1] = tone;
-}
-
-export function getPrefixTone(): PrefixTone {
-  return prefixTones[prefixTones.length - 1] ?? "neutral";
-}
-
-export function formatPrefixSymbol(symbol: string, tone: PrefixTone = getPrefixTone()): string {
-  switch (tone) {
-    case "active":
-      return cyan(symbol);
-    case "error":
-      return yellow(symbol);
-    case "cancel":
-      return red(symbol);
-    case "success":
-      return green(symbol);
-    case "neutral":
-      return dim(symbol);
-  }
+  prefixDepth = Math.max(0, prefixDepth - 1);
 }
 
 /** True while an intro/outro block is active and stderr output is gutter-prefixed. */
 export function isInsideGutter(): boolean {
-  return prefixTones.length > 0;
+  return prefixDepth > 0;
 }
 
 function applyPrefix(msg: string): string {
-  if (prefixTones.length === 0) return msg;
-  const bar = formatPrefixSymbol(S_BAR);
+  if (prefixDepth === 0) return msg;
+  const bar = dim(S_BAR);
   if (!msg) return bar;
   return msg
     .split("\n")

packages/cli-core/src/lib/spinner.test.ts

@@ -1,13 +1,6 @@
 import { isHuman } from "../mode.ts";
 import { dim, cyan, green, red } from "./color.ts";
-import {
-  formatPrefixSymbol,
-  getPrefixTone,
-  popPrefix,
-  pushPrefix,
-  setPrefixTone,
-  type PrefixTone,
-} from "./log.ts";
+import { pushPrefix, popPrefix } from "./log.ts";
 
 const FRAMES = ["◒", "◐", "◓", "◑"];
 const INTERVAL = 80;
@@ -24,38 +17,36 @@ const isInteractive = () => stream.isTTY && !process.env.CI;
 // --- Public API ---
 
 /** Print intro bracket: ┌  title — prefixes log output with │ until outro(). */
-export function intro(title?: string, options: { tone?: PrefixTone } = {}) {
+export function intro(title?: string) {
   if (!isHuman()) return;
-  const tone = options.tone ?? "neutral";
-  const line = title ? `${formatPrefixSymbol(S_BAR_START, tone)}  ${title}` : dim(S_BAR_START);
+  const line = title ? `${dim(S_BAR_START)}  ${title}` : dim(S_BAR_START);
   stream.write(`${line}\n`);
-  pushPrefix(tone);
+  pushPrefix();
 }
 
 /** Print outro bracket: └  message — restores normal log output.
  *  Pass a string[] to render as next steps after the bracket. */
 export function outro(messageOrSteps?: string | readonly string[]) {
   if (!isHuman()) return;
-  const tone = getPrefixTone();
   popPrefix();
-  stream.write(`${formatPrefixSymbol(S_BAR, tone)}\n`);
+  stream.write(`${dim(S_BAR)}\n`);
 
   if (Array.isArray(messageOrSteps)) {
-    stream.write(`${formatPrefixSymbol(S_BAR_END, tone)}  ${dim("Next steps")}\n`);
+    stream.write(`${dim(S_BAR_END)}  ${dim("Next steps")}\n`);
     for (const step of messageOrSteps) {
       stream.write(`   ${cyan("\u2192")} ${step}\n`);
     }
     stream.write("\n");
   } else {
     const label = messageOrSteps ?? "Done";
-    stream.write(`${formatPrefixSymbol(S_BAR_END, tone)}  ${label}\n\n`);
+    stream.write(`${dim(S_BAR_END)}  ${label}\n\n`);
   }
 }
 
 /** Print a bar separator: │ */
 export function bar() {
   if (!isHuman()) return;
-  stream.write(`${formatPrefixSymbol(S_BAR)}\n`);
+  stream.write(`${dim(S_BAR)}\n`);
 }
 
 function createSpinner() {
@@ -114,8 +105,7 @@ export async function withSpinner<T>(
     s.stop(doneMessage ?? message.replace(/\.{3}$/, ""));
     return result;
   } catch (error) {
-    setPrefixTone("error");
-    s.error(message.replace(/\.{3}$/, ""));
+    s.error("Failed");
     throw error;
   }
 }