test: construct ApiError subclasses via fromBody in fixtures

Author: wyattjoh

packages/cli-core/src/commands/doctor/doctor.test.ts

@@ -346,7 +346,7 @@ describe("checkLinkedAppExists", () => {
     const ctx = createMockContext({
       token: "test_token",
       profile: mockProfile,
-      applicationError: new PlapiError(404, "Not found"),
+      applicationError: PlapiError.fromBody(404, "Not found"),
     });
     const result = await checkLinkedAppExists(ctx);
     expectCheck(result, {

packages/cli-core/src/commands/link/index.test.ts

@@ -587,7 +587,7 @@ describe("link", () => {
     test("shows picker with only create option when listApplications fails with 500", async () => {
       mockIsAgent.mockReturnValue(false);
       mockGetToken.mockResolvedValue("token");
-      mockListApplications.mockRejectedValue(new PlapiError(500, "Internal Server Error"));
+      mockListApplications.mockRejectedValue(PlapiError.fromBody(500, "Internal Server Error"));
       mockSearch.mockImplementation(
         async (config: {
           source: (term: string | undefined) => { name: string; value: string }[];
@@ -622,7 +622,7 @@ describe("link", () => {
     test("propagates listApplications errors that are not 5xx", async () => {
       mockIsAgent.mockReturnValue(false);
       mockGetToken.mockResolvedValue("token");
-      mockListApplications.mockRejectedValue(new PlapiError(401, "Unauthorized"));
+      mockListApplications.mockRejectedValue(PlapiError.fromBody(401, "Unauthorized"));
 
       await expect(runLink()).rejects.toBeInstanceOf(PlapiError);
     });
@@ -1248,7 +1248,7 @@ describe("link", () => {
       mockListApplications.mockResolvedValue([mockApp]);
       mockSearch.mockResolvedValue("__create_new__");
       mockInput.mockResolvedValue("My App");
-      mockCreateApplication.mockRejectedValue(new PlapiError(422, "Unprocessable Entity"));
+      mockCreateApplication.mockRejectedValue(PlapiError.fromBody(422, "Unprocessable Entity"));
 
       await expect(link()).rejects.toBeInstanceOf(PlapiError);
       expect(mockSetProfile).not.toHaveBeenCalled();
@@ -1265,7 +1265,7 @@ describe("link", () => {
         name: "My App",
         instances: [],
       });
-      mockFetchApplication.mockRejectedValue(new PlapiError(503, "Service Unavailable"));
+      mockFetchApplication.mockRejectedValue(PlapiError.fromBody(503, "Service Unavailable"));
 
       await expect(link()).rejects.toBeInstanceOf(PlapiError);
       expect(mockSetProfile).not.toHaveBeenCalled();

packages/cli-core/src/commands/users/create.test.ts

@@ -171,7 +171,7 @@ describe("users create", () => {
   test("prints raw BAPI validation errors to stdout for machine use", async () => {
     mockHandleBapiError.mockImplementation((error: unknown) => error instanceof BapiError);
     mockBapiRequest.mockRejectedValue(
-      new BapiError(
+      BapiError.fromBody(
         422,
         JSON.stringify({
           errors: [

packages/cli-core/src/lib/bapi-command.test.ts

@@ -43,7 +43,7 @@ describe("bapi-command", () => {
     const handled = await captured.run(() =>
       Promise.resolve(
         handleBapiError(
-          new BapiError(
+          BapiError.fromBody(
             422,
             JSON.stringify({
               errors: [