refactor(plapi): allow null active_domain and guard in deploy wizard

Author: wyattjoh

packages/cli-core/src/commands/deploy/index.test.ts

@@ -708,6 +708,30 @@ describe("deploy", () => {
       });
     });
 
+    test("throws a CliError when createProductionInstance returns no active_domain", async () => {
+      await linkedProject();
+      mockIsAgent.mockReturnValue(false);
+      mockConfirm.mockResolvedValueOnce(true).mockResolvedValueOnce(true);
+      mockInput.mockResolvedValueOnce("example.com");
+      mockCreateProductionInstance.mockResolvedValueOnce({
+        instance_id: "ins_prod_mock",
+        environment_type: "production" as const,
+        active_domain: null,
+        publishable_key: "pk_live_test",
+        secret_key: "sk_live_test",
+        cname_targets: [],
+      });
+
+      let thrown: unknown;
+      try {
+        await runDeploy({});
+      } catch (e) {
+        thrown = e;
+      }
+      expect(thrown).toBeInstanceOf(CliError);
+      expect((thrown as CliError).message).toContain("did not return a domain");
+    });
+
     test("Ctrl-C at the DNS handoff reports paused", async () => {
       await linkedProject();
       mockIsAgent.mockReturnValue(false);

packages/cli-core/src/commands/deploy/index.ts

@@ -2,7 +2,7 @@ import { isAgent } from "../../mode.ts";
 import { isInsideGutter, log } from "../../lib/log.ts";
 import { sleep } from "../../lib/sleep.ts";
 import { bar, intro, outro, withSpinner } from "../../lib/spinner.ts";
-import { UserAbortError, isPromptExitError, throwUsageError } from "../../lib/errors.ts";
+import { CliError, UserAbortError, isPromptExitError, throwUsageError } from "../../lib/errors.ts";
 import { resolveProfile, setProfile } from "../../lib/config.ts";
 import {
   createProductionInstance as apiCreateProductionInstance,
@@ -217,6 +217,14 @@ async function startNewDeploy(ctx: DeployContext): Promise<void> {
   }
   const production = productionOrExists;
   await persistProductionInstance(ctx, production.instance_id);
+
+  if (!production.active_domain) {
+    throw new CliError(
+      "Production instance was created but Clerk did not return a domain. " +
+        "Run `clerk deploy` again to retry domain provisioning.",
+    );
+  }
+
   log.blank();
 
   const productionDomain = production.active_domain.name;

packages/cli-core/src/lib/plapi.ts

@@ -174,7 +174,7 @@ export type ListApplicationDomainsResponse = {
 export type ProductionInstanceResponse = {
   instance_id: string;
   environment_type: "production";
-  active_domain: DomainSummary;
+  active_domain: DomainSummary | null;
   secret_key?: string;
   publishable_key: string;
   cname_targets: CnameTarget[];