Skip to content

ci: pin Node.js 22 in release and e2e workflows#353

Merged
wyattjoh merged 2 commits into
mainfrom
wyattjoh/refresh-fixtures-fixes
Jun 17, 2026
Merged

ci: pin Node.js 22 in release and e2e workflows#353
wyattjoh merged 2 commits into
mainfrom
wyattjoh/refresh-fixtures-fixes

Conversation

@wyattjoh

@wyattjoh wyattjoh commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

What

  • Pin release npm publishing jobs to Node.js 22 instead of the floating lts/* value.
  • Add an explicit Node.js 22 setup to the E2E fixture refresh workflow.

Why

The release and fixture-refresh workflows should use the same explicit Node.js major as CI so npm publishing and E2E fixture generation do not fall back to Node.js 20.

Testing

  • bun run format
  • bun run format:check
  • git diff --check

@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4affe27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wyattjoh wyattjoh changed the title ci: pin release publish jobs to node 22 ci: pin Node.js 22 in release and e2e workflows Jun 17, 2026
@wyattjoh wyattjoh enabled auto-merge (squash) June 17, 2026 21:31
@wyattjoh wyattjoh merged commit 1c3bd93 into main Jun 17, 2026
9 checks passed
@wyattjoh wyattjoh deleted the wyattjoh/refresh-fixtures-fixes branch June 17, 2026 21:31
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 611c9dbe-51e1-48f9-ab0d-4f13280f728f

📥 Commits

Reviewing files that changed from the base of the PR and between 6fb32db and 4affe27.

📒 Files selected for processing (2)
  • .github/workflows/refresh-fixtures.yml
  • .github/workflows/release.yml

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


📝 Walkthrough

Walkthrough

Two GitHub Actions workflow files are updated to standardize on Node.js 22. In .github/workflows/refresh-fixtures.yml, a new actions/setup-node@v6 step is inserted before the Bun installation step, configuring node-version: 22. In .github/workflows/release.yml, the node-version field is changed from "lts/*" to 22 in the publish-npm, canary-publish-npm, and snapshot-publish jobs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants