You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The scripts/refresh-e2e-fixtures.ts script is refactored from a standalone executable into a module that exports refreshFixtures(options?). The function accepts injectable runScaffold and resolveDependencyVersion hooks, configurable directory overrides, and an optional onlyName filter. Scaffold failures are accumulated in a failedFixtures array that is returned rather than causing immediate process exit; main() sets process.exitCode = 1 based on the result. New internal types (CommandResult, ScaffoldRunner) and a runScaffoldCommand helper normalize Bun process output. The react-router fixture's scaffoldCmd in test/e2e/fixtures.manifest.ts gains --no-git-init. A new Bun test file covers the manifest flag assertion and the failure-accumulation path of refreshFixtures().
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name
Status
Explanation
Resolution
Docstring Coverage
⚠️ Warning
Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.
Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name
Status
Explanation
Title check
✅ Passed
The title 'fix(test): fail refresh fixtures on scaffold errors' directly and clearly summarizes the main change: ensuring fixture refreshes fail when scaffold errors occur.
Description check
✅ Passed
The description is well-related to the changeset, covering the three main changes: adding --no-git-init flag, making fixture refreshes aggregate failures and exit nonzero, and adding test coverage.
Linked Issues check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
✅ Passed
Check skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
--no-git-initto the React Router fixture scaffold command.Why
The refresh fixtures workflow could log a scaffold failure, skip that fixture, and still complete successfully, producing partial refresh PRs.