Skip to content

fix(test): fail refresh fixtures on scaffold errors#356

Merged
wyattjoh merged 1 commit into
mainfrom
wyattjoh/e2e-fixture-fix
Jun 17, 2026
Merged

fix(test): fail refresh fixtures on scaffold errors#356
wyattjoh merged 1 commit into
mainfrom
wyattjoh/e2e-fixture-fix

Conversation

@wyattjoh

Copy link
Copy Markdown
Contributor

What

  • Add --no-git-init to the React Router fixture scaffold command.
  • Make fixture refreshes attempt all requested scaffolders, then exit nonzero if any scaffold failed.
  • Add regression coverage for the React Router flag and aggregated scaffold failure behavior.

Why

The refresh fixtures workflow could log a scaffold failure, skip that fixture, and still complete successfully, producing partial refresh PRs.

@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0a5047d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wyattjoh wyattjoh merged commit 2573eb4 into main Jun 17, 2026
9 of 10 checks passed
@wyattjoh wyattjoh deleted the wyattjoh/e2e-fixture-fix branch June 17, 2026 22:12
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The scripts/refresh-e2e-fixtures.ts script is refactored from a standalone executable into a module that exports refreshFixtures(options?). The function accepts injectable runScaffold and resolveDependencyVersion hooks, configurable directory overrides, and an optional onlyName filter. Scaffold failures are accumulated in a failedFixtures array that is returned rather than causing immediate process exit; main() sets process.exitCode = 1 based on the result. New internal types (CommandResult, ScaffoldRunner) and a runScaffoldCommand helper normalize Bun process output. The react-router fixture's scaffoldCmd in test/e2e/fixtures.manifest.ts gains --no-git-init. A new Bun test file covers the manifest flag assertion and the failure-accumulation path of refreshFixtures().

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(test): fail refresh fixtures on scaffold errors' directly and clearly summarizes the main change: ensuring fixture refreshes fail when scaffold errors occur.
Description check ✅ Passed The description is well-related to the changeset, covering the three main changes: adding --no-git-init flag, making fixture refreshes aggregate failures and exit nonzero, and adding test coverage.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants