Skip to content

Commit 58aa895

Browse files
iagodahlemLauraBeatris
authored andcommitted
chore(ui): tidy ResetConnectionDialog per review feedback
Updates the dialog test name to read as a behavioral assertion and removes the verbose confirmation value comment now that the prop name carries the intent on its own.
1 parent 020833b commit 58aa895

2 files changed

Lines changed: 1 addition & 7 deletions

File tree

packages/ui/src/components/ConfigureSSO/ResetConnectionDialog.tsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,6 @@ import { useWizard } from './elements/Wizard';
1616
type ResetConnectionDialogProps = {
1717
isOpen: boolean;
1818
onClose: () => void;
19-
/**
20-
* The string the user must type to enable the destructive submit button.
21-
* Today this is the organization name; long-term it may swap to the
22-
* connection's domain — the dialog stays agnostic so callers own the
23-
* canonical value.
24-
*/
2519
confirmationValue: string;
2620
};
2721

packages/ui/src/components/ConfigureSSO/__tests__/ResetConnectionDialog.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ const resetMocks = () => {
7777
};
7878

7979
describe('ResetConnectionDialog', () => {
80-
it('returns null when isOpen is false', async () => {
80+
it('does not render when `isOpen` is `false`', async () => {
8181
resetMocks();
8282
const { wrapper } = await createFixtures();
8383
renderDialog(wrapper, { isOpen: false });

0 commit comments

Comments
 (0)