fix(clerk-js,shared,types): Support calling password without identifier (#6534)

Author: dstaley

.changeset/young-cats-retire.md

@@ -0,0 +1,7 @@
+---
+'@clerk/clerk-js': minor
+'@clerk/shared': minor
+'@clerk/types': minor
+---
+
+[Experimental] Signals: Add support for calling `signIn.password()` without an identifier.

packages/clerk-js/src/core/resources/SignIn.ts

@@ -493,12 +493,18 @@ class SignInFuture implements SignInFutureResource {
     submitPassword: this.submitResetPassword.bind(this),
   };
 
+  fetchStatus: 'idle' | 'fetching' = 'idle';
+
   constructor(readonly resource: SignIn) {}
 
   get status() {
     return this.resource.status;
   }
 
+  get availableStrategies() {
+    return this.resource.supportedFirstFactors ?? [];
+  }
+
   async sendResetPasswordEmailCode(): Promise<{ error: unknown }> {
     eventBus.emit('resource:error', { resource: this.resource, error: null });
     try {
@@ -583,12 +589,13 @@ class SignInFuture implements SignInFutureResource {
     }
   }
 
-  async password({ identifier, password }: { identifier: string; password: string }): Promise<{ error: unknown }> {
+  async password({ identifier, password }: { identifier?: string; password: string }): Promise<{ error: unknown }> {
     eventBus.emit('resource:error', { resource: this.resource, error: null });
+    const previousIdentifier = this.resource.identifier;
     try {
       await this.resource.__internal_basePost({
         path: this.resource.pathRoot,
-        body: { identifier, password },
+        body: { identifier: identifier || previousIdentifier, password },
       });
     } catch (err: unknown) {
       eventBus.emit('resource:error', { resource: this.resource, error: err });
@@ -678,4 +685,20 @@ class SignInFuture implements SignInFutureResource {
 
     return { error: null };
   }
+
+  async finalize(): Promise<{ error: unknown }> {
+    eventBus.emit('resource:error', { resource: this.resource, error: null });
+    try {
+      if (!this.resource.createdSessionId) {
+        throw new Error('Cannot finalize sign-in without a created session.');
+      }
+
+      await SignIn.clerk.setActive({ session: this.resource.createdSessionId });
+    } catch (err: unknown) {
+      eventBus.emit('resource:error', { resource: this.resource, error: err });
+      return { error: err };
+    }
+
+    return { error: null };
+  }
 }

packages/shared/src/error.ts

@@ -82,7 +82,7 @@ export function isKnownError(error: any): error is ClerkAPIResponseError | Clerk
  * @internal
  */
 export function isClerkAPIResponseError(err: any): err is ClerkAPIResponseError {
-  return 'clerkError' in err;
+  return err && 'clerkError' in err;
 }
 
 /**

packages/types/src/signIn.ts

@@ -126,9 +126,16 @@ export interface SignInResource extends ClerkResource {
 }
 
 export interface SignInFutureResource {
+  fetchStatus: 'idle' | 'fetching';
+  availableStrategies: SignInFirstFactor[];
   status: SignInStatus | null;
-  create: (params: { identifier: string }) => Promise<{ error: unknown }>;
-  password: (params: { identifier: string; password: string }) => Promise<{ error: unknown }>;
+  create: (params: {
+    identifier?: string;
+    strategy?: OAuthStrategy | 'saml' | 'enterprise_sso';
+    redirectUrl?: string;
+    actionCompleteRedirectUrl?: string;
+  }) => Promise<{ error: unknown }>;
+  password: (params: { identifier?: string; password: string }) => Promise<{ error: unknown }>;
   emailCode: {
     sendCode: (params: { email: string }) => Promise<{ error: unknown }>;
     verifyCode: (params: { code: string }) => Promise<{ error: unknown }>;
@@ -144,6 +151,7 @@ export interface SignInFutureResource {
     redirectUrl: string;
     redirectUrlComplete: string;
   }) => Promise<{ error: unknown }>;
+  finalize: () => Promise<{ error: unknown }>;
 }
 
 export type SignInStatus =