Skip to content

Commit 7bd72fe

Browse files
committed
chore(ui): rename ConfigureSSO descriptors and wire missing sites
Renames the 9 configureSSOWizard* element descriptors to match the post-refactor primitive layout (configureSSOHeader / configureSSOStepper* / configureSSOStep / configureSSOStepCounter / configureSSOFooter*), adds them at every site that previously had a TODO placeholder (Stepper Root + Item + Skeleton, Step.Counter, ProfileCardHeader), and drops the legacy entries from elementDescriptors.ts and the appearance.ts ElementsConfig type. Also aligns the ConfigureStep elementId from 'create-app' to 'configure' to match the wizard step id.
1 parent 80a1933 commit 7bd72fe

10 files changed

Lines changed: 45 additions & 40 deletions

File tree

packages/ui/src/components/ConfigureSSO/elements/ProfileCard.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ type ProfileCardHeaderProps = React.PropsWithChildren;
66
export const ProfileCardHeader = (props: ProfileCardHeaderProps): JSX.Element => (
77
<Flex
88
as='header'
9+
elementDescriptor={descriptors.configureSSOHeader}
910
{...props}
1011
sx={theme => ({
1112
gap: theme.space.$2,
@@ -22,7 +23,7 @@ type ProfileCardFooterProps = React.PropsWithChildren;
2223
export const ProfileCardFooter = (props: ProfileCardFooterProps): JSX.Element => (
2324
<Flex
2425
as='footer'
25-
elementDescriptor={descriptors.footer}
26+
elementDescriptor={descriptors.configureSSOFooter}
2627
align='center'
2728
justify='end'
2829
{...props}

packages/ui/src/components/ConfigureSSO/elements/Step.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ const FooterPrevious = ({ onClick, isDisabled, isLoading, label = 'Previous' }:
115115

116116
return (
117117
<Button
118-
elementDescriptor={descriptors.configureSSOWizardFooterPreviousButton}
118+
elementDescriptor={descriptors.configureSSOFooterPreviousButton}
119119
variant='outline'
120120
size='sm'
121121
isDisabled={isDisabled}
@@ -144,7 +144,7 @@ const FooterContinue = ({ onClick, isDisabled, isLoading, label = 'Continue' }:
144144

145145
return (
146146
<Button
147-
elementDescriptor={descriptors.configureSSOWizardFooterContinueButton}
147+
elementDescriptor={descriptors.configureSSOFooterContinueButton}
148148
variant='solid'
149149
size='sm'
150150
isDisabled={isDisabled}
@@ -182,7 +182,7 @@ const Counter = ({ total, current }: StepCounterProps): JSX.Element | null => {
182182

183183
return (
184184
<Badge
185-
// TODO: add descriptor
185+
elementDescriptor={descriptors.configureSSOStepCounter}
186186
colorScheme='primary'
187187
sx={{ whiteSpace: 'nowrap' }}
188188
>

packages/ui/src/components/ConfigureSSO/elements/Stepper/Stepper.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from 'react';
22

3-
import { Box, Button, Flex, Icon, Text, useLocalizations } from '@/customizables';
3+
import { Box, Button, descriptors, Flex, Icon, Text, useLocalizations } from '@/customizables';
44
import { CaretRight } from '@/icons';
55

66
import type { StepperItemProps, StepperProps } from './types';
@@ -10,7 +10,7 @@ const Root = ({ children }: StepperProps): JSX.Element => {
1010

1111
return (
1212
<Flex
13-
// TODO: add descriptor
13+
elementDescriptor={descriptors.configureSSOStepper}
1414
align='center'
1515
sx={theme => ({
1616
gap: theme.space.$2,
@@ -23,7 +23,7 @@ const Root = ({ children }: StepperProps): JSX.Element => {
2323
{child}
2424
{index < items.length - 1 && (
2525
<Icon
26-
// TODO: add descriptor
26+
elementDescriptor={descriptors.configureSSOStepperSeparator}
2727
icon={CaretRight}
2828
size='md'
2929
sx={theme => ({ color: theme.colors.$colorMutedForeground })}
@@ -48,7 +48,7 @@ const Item = ({
4848

4949
return (
5050
<Button
51-
// TODO: add descriptor
51+
elementDescriptor={descriptors.configureSSOStepperItem}
5252
isActive={isCurrent}
5353
variant='unstyled'
5454
isDisabled={!isReachable}
@@ -60,7 +60,7 @@ const Item = ({
6060
})}
6161
>
6262
<Flex
63-
// TODO: add descriptor
63+
elementDescriptor={descriptors.configureSSOStepperItemBullet}
6464
isActive={isCurrent}
6565
align='center'
6666
justify='center'
@@ -78,7 +78,7 @@ const Item = ({
7878
{bullet}
7979
</Flex>
8080
<Text
81-
// TODO: add descriptor
81+
elementDescriptor={descriptors.configureSSOStepperItemLabel}
8282
as='span'
8383
variant='body'
8484
sx={{ fontWeight: 'inherit', color: 'inherit' }}
@@ -120,7 +120,7 @@ type SkeletonProps = {
120120

121121
const Skeleton = ({ totalSteps = 4 }: SkeletonProps): JSX.Element => (
122122
<Flex
123-
// TODO: add descriptor
123+
elementDescriptor={descriptors.configureSSOStepper}
124124
align='center'
125125
sx={theme => ({
126126
gap: theme.space.$2,
@@ -133,7 +133,7 @@ const Skeleton = ({ totalSteps = 4 }: SkeletonProps): JSX.Element => (
133133
<ItemSkeleton />
134134
{index < totalSteps - 1 && (
135135
<Icon
136-
// TODO: add descriptor
136+
elementDescriptor={descriptors.configureSSOStepperSeparator}
137137
icon={CaretRight}
138138
size='md'
139139
sx={theme => ({ color: theme.colors.$neutralAlpha100 })}

packages/ui/src/components/ConfigureSSO/steps/ConfigureStep.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ export const ConfigureStep = (): JSX.Element => {
99
return (
1010
<Flow.Part part='configureCreateApp'>
1111
<Step
12-
elementDescriptor={descriptors.configureSSOWizardBody}
13-
elementId={descriptors.configureSSOWizardBody.setId('create-app')}
12+
elementDescriptor={descriptors.configureSSOStep}
13+
elementId={descriptors.configureSSOStep.setId('configure')}
1414
>
1515
<Step.Header
1616
title='Configure Okta Workforce'

packages/ui/src/components/ConfigureSSO/steps/ConfirmationStep.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ export const ConfirmationStep = (): JSX.Element => {
99
return (
1010
<Flow.Part part='sso-confirmation'>
1111
<Step
12-
elementDescriptor={descriptors.configureSSOWizardBody}
13-
elementId={descriptors.configureSSOWizardBody.setId('confirmation')}
12+
elementDescriptor={descriptors.configureSSOStep}
13+
elementId={descriptors.configureSSOStep.setId('confirmation')}
1414
>
1515
<Step.Body>
1616
<Step.Section

packages/ui/src/components/ConfigureSSO/steps/SelectProviderStep.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ export const SelectProviderStep = (): JSX.Element => {
99
return (
1010
<Flow.Part part='selectProvider'>
1111
<Step
12-
elementDescriptor={descriptors.configureSSOWizardBody}
13-
elementId={descriptors.configureSSOWizardBody.setId('select-provider')}
12+
elementDescriptor={descriptors.configureSSOStep}
13+
elementId={descriptors.configureSSOStep.setId('select-provider')}
1414
>
1515
<Step.Header
1616
title='Select provider'

packages/ui/src/components/ConfigureSSO/steps/TestConfigurationStep.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ export const TestConfigurationStep = (): JSX.Element => {
99
return (
1010
<Flow.Part part='test-sso'>
1111
<Step
12-
elementDescriptor={descriptors.configureSSOWizardBody}
13-
elementId={descriptors.configureSSOWizardBody.setId('test')}
12+
elementDescriptor={descriptors.configureSSOStep}
13+
elementId={descriptors.configureSSOStep.setId('test')}
1414
>
1515
<Step.Header
1616
title='Test your SSO connection'

packages/ui/src/components/ConfigureSSO/steps/VerifyDomainStep.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ export const VerifyDomainStep = (): JSX.Element => {
1212
return (
1313
<Flow.Part part='verifyDomain'>
1414
<Step
15-
elementDescriptor={descriptors.configureSSOWizardBody}
16-
elementId={descriptors.configureSSOWizardBody.setId('verify-domain')}
15+
elementDescriptor={descriptors.configureSSOStep}
16+
elementId={descriptors.configureSSOStep.setId('verify-domain')}
1717
>
1818
<Wizard>
1919
<Step.Header

packages/ui/src/customizables/elementDescriptors.ts

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -536,15 +536,17 @@ export const APPEARANCE_KEYS = containsAllElementsConfigKeys([
536536
'enterpriseConnectionButton',
537537
'enterpriseConnectionButtonText',
538538

539-
'configureSSOWizardHeader',
540-
'configureSSOWizardHeaderItem',
541-
'configureSSOWizardHeaderItemBullet',
542-
'configureSSOWizardHeaderItemLabel',
543-
'configureSSOWizardHeaderSeparator',
544-
'configureSSOWizardBody',
545-
'configureSSOWizardStepIndicator',
546-
'configureSSOWizardFooterPreviousButton',
547-
'configureSSOWizardFooterContinueButton',
539+
'configureSSOHeader',
540+
'configureSSOStepper',
541+
'configureSSOStepperItem',
542+
'configureSSOStepperItemBullet',
543+
'configureSSOStepperItemLabel',
544+
'configureSSOStepperSeparator',
545+
'configureSSOStep',
546+
'configureSSOStepCounter',
547+
'configureSSOFooter',
548+
'configureSSOFooterPreviousButton',
549+
'configureSSOFooterContinueButton',
548550

549551
'web3SolanaWalletButtonsRoot',
550552
'web3SolanaWalletButtons',

packages/ui/src/internal/appearance.ts

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -672,15 +672,17 @@ export type ElementsConfig = {
672672
enterpriseConnectionButton: WithOptions;
673673
enterpriseConnectionButtonText: WithOptions;
674674

675-
configureSSOWizardHeader: WithOptions;
676-
configureSSOWizardHeaderItem: WithOptions<string, ActiveState>;
677-
configureSSOWizardHeaderItemBullet: WithOptions<string, ActiveState>;
678-
configureSSOWizardHeaderItemLabel: WithOptions<string>;
679-
configureSSOWizardHeaderSeparator: WithOptions;
680-
configureSSOWizardBody: WithOptions<string>;
681-
configureSSOWizardStepIndicator: WithOptions;
682-
configureSSOWizardFooterPreviousButton: WithOptions;
683-
configureSSOWizardFooterContinueButton: WithOptions;
675+
configureSSOHeader: WithOptions;
676+
configureSSOStepper: WithOptions;
677+
configureSSOStepperItem: WithOptions<string, ActiveState>;
678+
configureSSOStepperItemBullet: WithOptions<string, ActiveState>;
679+
configureSSOStepperItemLabel: WithOptions<string>;
680+
configureSSOStepperSeparator: WithOptions;
681+
configureSSOStep: WithOptions<string>;
682+
configureSSOStepCounter: WithOptions;
683+
configureSSOFooter: WithOptions;
684+
configureSSOFooterPreviousButton: WithOptions;
685+
configureSSOFooterContinueButton: WithOptions;
684686

685687
web3SolanaWalletButtonsRoot: WithOptions;
686688
web3SolanaWalletButtons: WithOptions;

0 commit comments

Comments
 (0)