Skip to content

Commit 7fe00d6

Browse files
authored
fix(clerk-js): Ensure Base & Coinbase dependencies aren't bundled for non-RHC environments (#6742)
1 parent c0a643f commit 7fe00d6

3 files changed

Lines changed: 17 additions & 1 deletion

File tree

.changeset/funny-laws-fetch.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@clerk/clerk-js': patch
3+
---
4+
5+
Remove Base for non-RHC environments to ensure Coinbase dependencies aren't bundled.

packages/clerk-js/rspack.config.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,9 @@ const common = ({ mode, variant, disableRHC = false }) => {
8282
* SDKs such as Browser Extensions.
8383
*/
8484
// TODO: @COMMERCE: Do we still need this?
85-
externals: disableRHC ? ['@stripe/stripe-js', '@stripe/react-stripe-js'] : undefined,
85+
externals: disableRHC
86+
? ['@stripe/stripe-js', '@stripe/react-stripe-js', '@coinbase/wallet-sdk', '@base-org/account']
87+
: undefined,
8688
optimization: {
8789
splitChunks: {
8890
cacheGroups: {
@@ -479,6 +481,12 @@ const prodConfig = ({ mode, env, analysis }) => {
479481
new rspack.IgnorePlugin({
480482
resourceRegExp: /^@stripe\/stripe-js$/,
481483
}),
484+
new rspack.IgnorePlugin({
485+
resourceRegExp: /^@coinbase\/wallet-sdk$/,
486+
}),
487+
new rspack.IgnorePlugin({
488+
resourceRegExp: /^@base-org\/account$/,
489+
}),
482490
new rspack.optimize.LimitChunkCountPlugin({
483491
maxChunks: 1,
484492
}),

scripts/search-for-rhc.mjs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,11 @@ await Promise.allSettled([
2828
asyncSearchRHC('Turnstile', 'cloudflare.com/turnstile/v0/api.js'),
2929
asyncSearchRHC('clerk-js Hotloading', '/npm/@clerk/clerk-js'),
3030
asyncSearchRHC('Google One Tap', 'accounts.google.com/gsi/client'),
31+
asyncSearchRHC('Coinbase', 'coinbase.com'),
32+
asyncSearchRHC('Coinbase Wallet import', 'import\s*"@coinbase/wallet-sdk', true), // eslint-disable-line no-useless-escape
3133
asyncSearchRHC('Stripe', 'js.stripe.com'),
3234
asyncSearchRHC('Stripe import', 'import\s*"@stripe/stripe-js', true), // eslint-disable-line no-useless-escape
35+
asyncSearchRHC('Base import', 'import\s*"@base-org/account', true), // eslint-disable-line no-useless-escape
3336
]).then(results => {
3437
const errors = results.filter(result => result.status === 'rejected').map(result => result.reason.message);
3538

0 commit comments

Comments
 (0)